Skip to content

Detail APIs for datetime functions - #7430

Merged
rapids-bot[bot] merged 4 commits into
NVIDIA:branch-0.19from
magnatelee:detail-api-datetime
Feb 25, 2021
Merged

Detail APIs for datetime functions#7430
rapids-bot[bot] merged 4 commits into
NVIDIA:branch-0.19from
magnatelee:detail-api-datetime

Conversation

@magnatelee

Copy link
Copy Markdown
Contributor

This PR adds detail APIs for datetime functions so that users can pass stream arguments to them.

@magnatelee
magnatelee requested a review from a team as a code owner February 23, 2021 22:21
@github-actions github-actions Bot added the libcudf Affects libcudf (C++/CUDA) code. label Feb 23, 2021
@magnatelee
magnatelee requested a review from kkraus14 February 23, 2021 22:26
@kkraus14 kkraus14 added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Feb 23, 2021
@github-actions github-actions Bot added the conda label Feb 23, 2021
@codecov

codecov Bot commented Feb 24, 2021

Copy link
Copy Markdown

Codecov Report

Merging #7430 (de822a5) into branch-0.19 (43b44e1) will increase coverage by 0.46%.
The diff coverage is 96.66%.

Impacted file tree graph

@@               Coverage Diff               @@
##           branch-0.19    #7430      +/-   ##
===============================================
+ Coverage        81.80%   82.26%   +0.46%     
===============================================
  Files              101      101              
  Lines            16695    17072     +377     
===============================================
+ Hits             13658    14045     +387     
+ Misses            3037     3027      -10     
Impacted Files Coverage Δ
python/cudf/cudf/core/frame.py 89.35% <ø> (+0.09%) ⬆️
python/cudf/cudf/core/column_accessor.py 95.47% <95.65%> (+2.53%) ⬆️
python/cudf/cudf/core/dataframe.py 90.58% <100.00%> (+0.12%) ⬆️
python/cudf/cudf/io/feather.py 100.00% <0.00%> (ø)
python/cudf/cudf/comm/serialize.py 0.00% <0.00%> (ø)
python/cudf/cudf/_fuzz_testing/io.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/column/struct.py 100.00% <0.00%> (ø)
python/dask_cudf/dask_cudf/_version.py 0.00% <0.00%> (ø)
python/dask_cudf/dask_cudf/io/tests/test_csv.py 100.00% <0.00%> (ø)
python/dask_cudf/dask_cudf/io/tests/test_orc.py 100.00% <0.00%> (ø)
... and 40 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2234554...0428516. Read the comment docs.

@vuule vuule left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good; couple of small suggestions:

Comment thread cpp/include/cudf/detail/datetime.hpp Outdated
Comment thread cpp/src/datetime/datetime_ops.cu Outdated
@magnatelee
magnatelee requested a review from a team as a code owner February 24, 2021 19:12
@magnatelee
magnatelee requested a review from vuule February 24, 2021 19:13
@kkraus14 kkraus14 added the 4 - Needs Review Waiting for reviewer to review or respond label Feb 24, 2021

@davidwendt davidwendt left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. You should add 2021 to the copyright in datetime_ops.cu

@magnatelee

Copy link
Copy Markdown
Contributor Author

@davidwendt Thanks for catching it. I just added the year.

@kkraus14 kkraus14 added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 4 - Needs Review Waiting for reviewer to review or respond labels Feb 25, 2021
@kkraus14

Copy link
Copy Markdown
Contributor

@gpucibot merge

@kkraus14

Copy link
Copy Markdown
Contributor

Thanks @magnatelee!

@rapids-bot
rapids-bot Bot merged commit f30be67 into NVIDIA:branch-0.19 Feb 25, 2021
@magnatelee
magnatelee deleted the detail-api-datetime branch February 26, 2021 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

5 - Ready to Merge Testing and reviews complete, ready to merge improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants