Skip to content

Fix JNI build after removal of libcudf sub-libraries [skip ci] - #7486

Merged
rapids-bot[bot] merged 2 commits into
NVIDIA:branch-0.19from
jlowe:fix-jni-build
Mar 2, 2021
Merged

Fix JNI build after removal of libcudf sub-libraries [skip ci]#7486
rapids-bot[bot] merged 2 commits into
NVIDIA:branch-0.19from
jlowe:fix-jni-build

Conversation

@jlowe

@jlowe jlowe commented Mar 2, 2021

Copy link
Copy Markdown
Contributor

Fixing the Java bindings build after the removal of the libcudf sub-libraries in #7107.

@jlowe jlowe added bug Something isn't working CMake CMake build issue Java Affects Java cuDF API. 4 - Needs cuDF (Java) Reviewer non-breaking Non-breaking change labels Mar 2, 2021
@jlowe
jlowe requested a review from a team as a code owner March 2, 2021 19:35
@jlowe jlowe self-assigned this Mar 2, 2021
Comment thread java/pom.xml
@mythrocks

Copy link
Copy Markdown
Contributor

I'm 👍 on this. Kicking the tyres on this now.

@mythrocks

Copy link
Copy Markdown
Contributor

(Github does not allow me to add this comment because this section wasn't modified in the PR. :/)

We might need to modify the Arrow paths:

# Find static version of Arrow lib
find_library(ARROW_LIBRARY libarrow.a
  HINTS "$ENV{ARROW_ROOT}/lib"
        "$ENV{CONDA_PREFIX}/lib"
        "${CUDF_CPP_BUILD_DIR}/arrow/install/lib")

The build complains with: Arrow static libs not found. Was libcudf built with ARROW_STATIC_LIB=ON?, unless the last path is modified as follows:

find_library(ARROW_LIBRARY libarrow.a
  HINTS "$ENV{ARROW_ROOT}/lib"
        "$ENV{CONDA_PREFIX}/lib"
        "${CUDF_CPP_BUILD_DIR}/_deps/arrow-build/release")

The ARROW_INCLUDE path might need a similar change.

@jlowe

jlowe commented Mar 2, 2021

Copy link
Copy Markdown
Contributor Author

We might need to modify the Arrow paths

Thanks @mythrocks, this accidentally worked in my env because I had some old build artifacts around that it found. I updated the hints for the Arrow paths and verified with a clean build.

@mythrocks mythrocks left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mythrocks

Copy link
Copy Markdown
Contributor

@gpucibot merge

@rapids-bot
rapids-bot Bot merged commit 150df65 into NVIDIA:branch-0.19 Mar 2, 2021
@vyasr vyasr added 4 - Needs Review Waiting for reviewer to review or respond and removed 4 - Needs cuDF (Java) Reviewer labels Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4 - Needs Review Waiting for reviewer to review or respond bug Something isn't working CMake CMake build issue Java Affects Java cuDF API. non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants