Fix JNI build after removal of libcudf sub-libraries [skip ci] - #7486
Merged
Conversation
razajafri
reviewed
Mar 2, 2021
Contributor
|
I'm 👍 on this. Kicking the tyres on this now. |
revans2
approved these changes
Mar 2, 2021
Contributor
|
(Github does not allow me to add this comment because this section wasn't modified in the PR. :/) We might need to modify the Arrow paths: # Find static version of Arrow lib
find_library(ARROW_LIBRARY libarrow.a
HINTS "$ENV{ARROW_ROOT}/lib"
"$ENV{CONDA_PREFIX}/lib"
"${CUDF_CPP_BUILD_DIR}/arrow/install/lib")The build complains with: find_library(ARROW_LIBRARY libarrow.a
HINTS "$ENV{ARROW_ROOT}/lib"
"$ENV{CONDA_PREFIX}/lib"
"${CUDF_CPP_BUILD_DIR}/_deps/arrow-build/release")The |
Contributor
Author
Thanks @mythrocks, this accidentally worked in my env because I had some old build artifacts around that it found. I updated the hints for the Arrow paths and verified with a clean build. |
Contributor
|
@gpucibot merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing the Java bindings build after the removal of the libcudf sub-libraries in #7107.