Skip to content

Add Python bindings for lists::extract_lists_element - #7505

Merged
rapids-bot[bot] merged 15 commits into
NVIDIA:branch-0.19from
skirui-source:extract
Mar 23, 2021
Merged

Add Python bindings for lists::extract_lists_element#7505
rapids-bot[bot] merged 15 commits into
NVIDIA:branch-0.19from
skirui-source:extract

Conversation

@skirui-source

@skirui-source skirui-source commented Mar 3, 2021 •
edited by kkraus14
Loading

Copy link
Copy Markdown
Contributor

Fixes #7464

@skirui-source skirui-source added feature request New feature or request Cython non-breaking Non-breaking change labels Mar 3, 2021
@skirui-source
skirui-source requested review from isVoid and shwina March 3, 2021 17:20
@skirui-source skirui-source self-assigned this Mar 3, 2021
@github-actions github-actions Bot added the Python Affects Python cuDF API. label Mar 3, 2021
@skirui-source skirui-source added the 3 - Ready for Review Ready for review by team label Mar 13, 2021
kkraus14
kkraus14 reviewed Mar 15, 2021
View reviewed changes
Comment thread python/cudf/cudf/core/column/lists.py Outdated
kkraus14
kkraus14 reviewed Mar 15, 2021
View reviewed changes
Comment thread python/cudf/cudf/core/column/lists.py Outdated
isVoid
isVoid reviewed Mar 16, 2021
View reviewed changes
Comment thread python/cudf/cudf/core/column/lists.py Outdated
@skirui-source
skirui-source marked this pull request as ready for review March 17, 2021 07:51
@skirui-source
skirui-source requested a review from a team as a code owner March 17, 2021 07:51
kkraus14
kkraus14 reviewed Mar 18, 2021
View reviewed changes
Comment thread python/cudf/cudf/core/column/lists.py Outdated
kkraus14
kkraus14 reviewed Mar 18, 2021
View reviewed changes
Comment thread python/cudf/cudf/tests/test_list.py Outdated
kkraus14
kkraus14 reviewed Mar 18, 2021
View reviewed changes
Comment thread python/cudf/cudf/tests/test_list.py Outdated
kkraus14
kkraus14 reviewed Mar 20, 2021
View reviewed changes
Comment thread python/cudf/cudf/core/column/lists.py Outdated
kkraus14
kkraus14 reviewed Mar 20, 2021
View reviewed changes
Comment thread python/cudf/cudf/_lib/lists.pyx Outdated
isVoid
isVoid reviewed Mar 22, 2021
View reviewed changes

@isVoid isVoid left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A small comment, else lgtm!

Comment thread python/cudf/cudf/core/column/lists.py Outdated
kkraus14
kkraus14 approved these changes Mar 23, 2021
View reviewed changes

@kkraus14 kkraus14 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor formatting issue otherwise LGTM!

Comment thread python/cudf/cudf/_lib/cpp/lists/extract.pxd Outdated
@kkraus14

kkraus14 commented Mar 23, 2021

Copy link
Copy Markdown
Contributor

@gpucibot merge

@codecov

codecov Bot commented Mar 23, 2021 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #7505 (5c3b85b) into branch-0.19 (7871e7a) will increase coverage by 0.63%.
The diff coverage is n/a.

❗ Current head 5c3b85b differs from pull request most recent head b0a15bc. Consider uploading reports for the commit b0a15bc to get more accurate results
Impacted file tree graph

@@               Coverage Diff               @@
##           branch-0.19    #7505      +/-   ##
===============================================
+ Coverage        81.86%   82.49%   +0.63%     
===============================================
  Files              101      101              
  Lines            16884    17405     +521     
===============================================
+ Hits             13822    14359     +537     
+ Misses            3062     3046      -16
Impacted Files Coverage Δ
python/cudf/cudf/core/column/categorical.py 91.97% <ø> (+0.58%) ⬆️
python/cudf/cudf/core/column/column.py 87.86% <ø> (+0.10%) ⬆️
python/cudf/cudf/core/column/datetime.py 89.63% <ø> (+0.54%) ⬆️
python/cudf/cudf/core/column/decimal.py 92.75% <ø> (-2.12%) ⬇️
python/cudf/cudf/core/column/lists.py 92.50% <ø> (+1.10%) ⬆️
python/cudf/cudf/core/column/numerical.py 94.83% <ø> (-0.20%) ⬇️
python/cudf/cudf/core/column/string.py 86.79% <ø> (+0.30%) ⬆️
python/cudf/cudf/core/column/timedelta.py 88.57% <ø> (+0.33%) ⬆️
python/cudf/cudf/core/column_accessor.py 95.45% <ø> (+0.14%) ⬆️
python/cudf/cudf/core/dataframe.py 90.90% <ø> (+0.44%) ⬆️
... and 61 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd1f3ea...b0a15bc. Read the comment docs.

@rapids-bot
rapids-bot Bot merged commit e07762c into NVIDIA:branch-0.19 Mar 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shwina shwina Awaiting requested review from shwina
@isVoid isVoid Awaiting requested review from isVoid
1 more reviewer
@kkraus14 kkraus14 kkraus14 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@skirui-source skirui-source

Labels

3 - Ready for Review Ready for review by team feature request New feature or request non-breaking Non-breaking change Python Affects Python cuDF API.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[FEA] Python bindings for lists::extract_lists_element

4 participants

@skirui-source @kkraus14 @shwina @isVoid