Remove unneeded step parameter from strings::detail::copy_slice - #7525
Merged
rapids-bot[bot] merged 9 commits intoMar 11, 2021
Merged
Conversation
davidwendt
added
3 - Ready for Review
Codecov Report
@@ Coverage Diff @@
## branch-0.19 #7525 +/- ##
===============================================
+ Coverage 81.86% 82.38% +0.51%
===============================================
Files 101 101
Lines 16884 17339 +455
===============================================
+ Hits 13822 14284 +462
+ Misses 3062 3055 -7
Continue to review full report at Codecov.
|
hyperbolic2346
requested changes
Mar 6, 2021
hyperbolic2346
left a comment
hyperbolic2346
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me.
ajschmidt8
approved these changes
Mar 8, 2021
hyperbolic2346
approved these changes
Mar 8, 2021
Contributor
Author
|
rerun tests |
davidwendt
added
breaking
jrhemstad
approved these changes
Mar 11, 2021
Contributor
Author
|
@gpucibot merge |
hyperbolic2346
pushed a commit
to hyperbolic2346/cudf
that referenced
this pull request
Mar 25, 2021
…IA#7525) This started to be a change converting some `device_vector` usages in `cpp/src/strings` source files to use `device_uvector` instead. The `cpp/src/strings/copying/copying.cu` source has the implementation for `cudf::strings::detail::copy_slice()` and used a `device_vector` to handle a `step` parameter. I can not longer find this parameter being used. I believe it was a hold over from porting nvstrings. So this PR mainly includes changes for removing this unneeded parameter which also removes the need for the `device_vector` or temporary memory in this function. And, it also includes changes to `attributes.cu` to use the `device_uvector` as well. ~~I'm marking this as non-breaking change since it is a change to a `detail` API and did not seem to be used anywhere in this repo.~~ Reference NVIDIA#7287 Authors: - David (@davidwendt) Approvers: - AJ Schmidt (@ajschmidt8) - Mike Wilson (@hyperbolic2346) - Jake Hemstad (@jrhemstad) URL: NVIDIA#7525
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This started to be a change converting some
device_vectorusages incpp/src/stringssource files to usedevice_uvectorinstead. Thecpp/src/strings/copying/copying.cusource has the implementation forcudf::strings::detail::copy_slice()and used adevice_vectorto handle astepparameter. I can not longer find this parameter being used. I believe it was a hold over from porting nvstrings. So this PR mainly includes changes for removing this unneeded parameter which also removes the need for thedevice_vectoror temporary memory in this function.And, it also includes changes to
attributes.cuto use thedevice_uvectoras well.I'm marking this as non-breaking change since it is a change to adetailAPI and did not seem to be used anywhere in this repo.Reference #7287