Skip to content

fix missing renames of dask git branches from master to main [skip ci] - #7535

Merged
rapids-bot[bot] merged 1 commit into
NVIDIA:branch-0.19from
kkraus14:dask_main_branch
Mar 9, 2021
Merged

fix missing renames of dask git branches from master to main [skip ci]#7535
rapids-bot[bot] merged 1 commit into
NVIDIA:branch-0.19from
kkraus14:dask_main_branch

Conversation

@kkraus14

@kkraus14 kkraus14 commented Mar 9, 2021

Copy link
Copy Markdown
Contributor

There were a few renames of master --> main that were missed for the recent dask branch rename, fixed them.

@kkraus14 kkraus14 added bug Something isn't working gpuCI non-breaking Non-breaking change labels Mar 9, 2021
@kkraus14
kkraus14 requested a review from a team as a code owner March 9, 2021 02:44
@github-actions github-actions Bot added the conda label Mar 9, 2021
@kkraus14 kkraus14 changed the title fix missing renames of dask git branches from master to main fix missing renames of dask git branches from master to main [skip ci] Mar 9, 2021
@kkraus14

kkraus14 commented Mar 9, 2021

Copy link
Copy Markdown
Contributor Author

rerun tests

Comment thread ci/benchmark/build.sh
@@ -75,10 +75,10 @@ conda install "rmm=$MINOR_VERSION.*" "cudatoolkit=$CUDA_REL" \
# conda install "your-pkg=1.0.0"

# Install the master version of dask, distributed, and streamz

@galipremsagar galipremsagar Mar 9, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Install the master version of dask, distributed, and streamz
# Install the latest version of dask, distributed, and streamz

@jakirkham

Copy link
Copy Markdown
Contributor

Not sure, but could this be causing the CI errors?

../include/cudf/detail/null_mask.cuh(26): error: namespace "cudf::detail" has no member "device_span"
 
../src/bitmask/null_mask.cu(47): error: namespace "cudf::detail" has no member "device_span"

@kkraus14

kkraus14 commented Mar 9, 2021

Copy link
Copy Markdown
Contributor Author

Not sure, but could this be causing the CI errors?

../include/cudf/detail/null_mask.cuh(26): error: namespace "cudf::detail" has no member "device_span"
 
../src/bitmask/null_mask.cu(47): error: namespace "cudf::detail" has no member "device_span"

That is fixed in #7533, but both are needed to unblock CI. Going to merge this as is.

@kkraus14

kkraus14 commented Mar 9, 2021

Copy link
Copy Markdown
Contributor Author

@gpucibot merge

@rapids-bot
rapids-bot Bot merged commit 8b2ae92 into NVIDIA:branch-0.19 Mar 9, 2021
hyperbolic2346 pushed a commit to hyperbolic2346/cudf that referenced this pull request Mar 25, 2021
…7535)

There were a few renames of master --> main that were missed for the recent dask branch rename, fixed them.

Authors:
  - Keith Kraus (@kkraus14)

Approvers:
  - AJ Schmidt (@ajschmidt8)
  - GALI PREM SAGAR (@galipremsagar)

URL: NVIDIA#7535
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants