Use rmm::device_uvector in place of rmm::device_vector for ORC reader/writer and cudf::io::column_buffer - #7614
Merged
rapids-bot[bot] merged 3 commits intoMar 20, 2021
Conversation
vuule
marked this pull request as ready for review
March 16, 2021 19:48
vuule
requested review from
jrhemstad,
kaatish,
ramakrishnap-nv and
trxcllnt
and removed request for
jrhemstad and
trxcllnt
March 16, 2021 19:48
Codecov Report
@@ Coverage Diff @@
## branch-0.19 #7614 +/- ##
===============================================
+ Coverage 81.86% 82.39% +0.52%
===============================================
Files 101 101
Lines 16884 17350 +466
===============================================
+ Hits 13822 14295 +473
+ Misses 3062 3055 -7
Continue to review full report at Codecov.
|
Contributor
Author
|
Rerun tests |
ramakrishnap-nv
approved these changes
Mar 17, 2021
kaatish
approved these changes
Mar 20, 2021
Contributor
Author
|
@gpucibot merge |
26 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #7287
Replaces
device_vectorwithdevice_uvectoranddevice_span. Becausedevice_uvectordoes not have a default constructor, some additional changes were required fordevice_uvectordata members.Performance impact: this change makes a measurable difference in reader benchmarks. Most string column cases are sped up around 5%, with other cases having a measurable, but less consistent improvement.