cudf_kafka now uses cuDF CMake export targets (CPM) - #7674
Merged
rapids-bot[bot] merged 8 commits intoMar 25, 2021
Merged
Conversation
github-actions
Bot
added
CMake
kkraus14
reviewed
Mar 23, 2021
kkraus14
reviewed
Mar 23, 2021
Contributor
Author
|
rerun tests |
1 similar comment
Contributor
|
rerun tests |
robertmaynard
force-pushed
the
fix/link_against_cpm_exports
branch
2 times, most recently
from
March 23, 2021 20:35
e4724cd to
052a3fa
Compare
rapids-bot Bot
pushed a commit
that referenced
this pull request
Mar 24, 2021
This rolls up all the cudf changes from #7674 that are necessary for `libcudf_kafka` to build against an installed version of `branch-0.19`. Authors: - Robert Maynard (@robertmaynard) Approvers: - Keith Kraus (@kkraus14) URL: #7688
robertmaynard
force-pushed
the
fix/link_against_cpm_exports
branch
from
March 24, 2021 01:42
4035d92 to
48b7d15
Compare
robertmaynard
changed the title
mike-wendt
approved these changes
Mar 24, 2021
Contributor
|
@robertmaynard Does this supersede #7484? |
Codecov Report
@@ Coverage Diff @@
## branch-0.19 #7674 +/- ##
===============================================
+ Coverage 81.86% 82.10% +0.24%
===============================================
Files 101 101
Lines 16884 17080 +196
===============================================
+ Hits 13822 14024 +202
+ Misses 3062 3056 -6
Continue to review full report at Codecov.
|
Contributor
Author
Yes |
kkraus14
reviewed
Mar 24, 2021
kkraus14
added
improvement
Contributor
|
rerun tests |
kkraus14
approved these changes
Mar 25, 2021
Contributor
|
@gpucibot merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This integrates the changes from #7484 plus others required to get
cudf_kafkato build cleanly after the CMake refactoring ofcudf