Skip to content

Use stream in groupby calls - #7705

Merged
rapids-bot[bot] merged 10 commits into
NVIDIA:branch-0.19from
karthikeyann:groupby_stream_usage
Mar 27, 2021
Merged

Use stream in groupby calls#7705
rapids-bot[bot] merged 10 commits into
NVIDIA:branch-0.19from
karthikeyann:groupby_stream_usage

Conversation

@karthikeyann

Copy link
Copy Markdown
Contributor

sort_groupby_helper::

  • sorted_values()
  • grouped_values()
  • unique_keys()
  • sorted_keys()
  • num_groups()
  • num_keys()
  • key_sort_order()
  • group_offsets()
  • group_labels()
  • unsorted_keys_labels()
  • keys_bitmask_column()

groupby::

  • - dispatch_aggregation()

@karthikeyann karthikeyann added 3 - Ready for Review Ready for review by team libcudf Affects libcudf (C++/CUDA) code. tech debt improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Mar 24, 2021
@karthikeyann
karthikeyann requested a review from a team as a code owner March 24, 2021 16:39
Comment thread cpp/include/cudf/detail/groupby/sort_helper.hpp Outdated
@codecov

codecov Bot commented Mar 24, 2021

Copy link
Copy Markdown

Codecov Report

Merging #7705 (b817be4) into branch-0.19 (7871e7a) will increase coverage by 0.64%.
The diff coverage is n/a.

❗ Current head b817be4 differs from pull request most recent head 87989c6. Consider uploading reports for the commit 87989c6 to get more accurate results
Impacted file tree graph

@@               Coverage Diff               @@
##           branch-0.19    #7705      +/-   ##
===============================================
+ Coverage        81.86%   82.50%   +0.64%     
===============================================
  Files              101      101              
  Lines            16884    17442     +558     
===============================================
+ Hits             13822    14391     +569     
+ Misses            3062     3051      -11     
Impacted Files Coverage Δ
python/cudf/cudf/core/buffer.py 84.21% <ø> (+4.96%) ⬆️
python/cudf/cudf/core/column/categorical.py 91.97% <ø> (+0.58%) ⬆️
python/cudf/cudf/core/column/column.py 87.61% <ø> (-0.15%) ⬇️
python/cudf/cudf/core/column/datetime.py 89.63% <ø> (+0.54%) ⬆️
python/cudf/cudf/core/column/decimal.py 92.75% <ø> (-2.12%) ⬇️
python/cudf/cudf/core/column/lists.py 90.00% <ø> (-1.40%) ⬇️
python/cudf/cudf/core/column/numerical.py 94.83% <ø> (-0.20%) ⬇️
python/cudf/cudf/core/column/string.py 86.79% <ø> (+0.30%) ⬆️
python/cudf/cudf/core/column/timedelta.py 88.57% <ø> (+0.33%) ⬆️
python/cudf/cudf/core/column_accessor.py 96.13% <ø> (+0.82%) ⬆️
... and 56 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 267d29b...87989c6. Read the comment docs.

@karthikeyann
karthikeyann requested a review from jrhemstad March 24, 2021 20:26
@karthikeyann karthikeyann added the 4 - Needs Review Waiting for reviewer to review or respond label Mar 25, 2021
@karthikeyann karthikeyann added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team 4 - Needs Review Waiting for reviewer to review or respond labels Mar 27, 2021
@karthikeyann

Copy link
Copy Markdown
Contributor Author

@gpucibot merge

@rapids-bot
rapids-bot Bot merged commit ccc28d5 into NVIDIA:branch-0.19 Mar 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

5 - Ready to Merge Testing and reviews complete, ready to merge improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants