Skip to content

[REVIEW] Fix return type of DataFrame.argsort - #7706

Merged
rapids-bot[bot] merged 1 commit into
NVIDIA:branch-0.19from
galipremsagar:7577
Mar 24, 2021
Merged

[REVIEW] Fix return type of DataFrame.argsort#7706
rapids-bot[bot] merged 1 commit into
NVIDIA:branch-0.19from
galipremsagar:7577

Conversation

@galipremsagar

Copy link
Copy Markdown
Contributor

Fixes: #7577

This PR fixes the return type of DataFrame.argsort to return cudf.Series instead of a NumericalColumn.

@galipremsagar galipremsagar added bug Something isn't working 3 - Ready for Review Ready for review by team Python Affects Python cuDF API. 4 - Needs cuDF (Python) Reviewer non-breaking Non-breaking change labels Mar 24, 2021
@galipremsagar galipremsagar self-assigned this Mar 24, 2021
@galipremsagar
galipremsagar requested a review from a team as a code owner March 24, 2021 16:56
@kkraus14 kkraus14 added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team 4 - Needs cuDF (Python) Reviewer labels Mar 24, 2021
@kkraus14

Copy link
Copy Markdown
Contributor

@gpucibot merge

@rapids-bot
rapids-bot Bot merged commit df3c0f0 into NVIDIA:branch-0.19 Mar 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

5 - Ready to Merge Testing and reviews complete, ready to merge bug Something isn't working non-breaking Non-breaking change Python Affects Python cuDF API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] DataFrame.argsort returns internal object

2 participants