Memory map the input file only when GDS compatiblity mode is not used - #7717
Merged
rapids-bot[bot] merged 9 commits intoMar 29, 2021
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## branch-0.19 #7717 +/- ##
===============================================
+ Coverage 81.86% 82.52% +0.65%
===============================================
Files 101 101
Lines 16884 17458 +574
===============================================
+ Hits 13822 14407 +585
+ Misses 3062 3051 -11
Continue to review full report at Codecov.
|
devavret
reviewed
Mar 26, 2021
devavret
approved these changes
Mar 29, 2021
davidwendt
approved these changes
Mar 29, 2021
Contributor
Author
|
@gpucibot merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mmapis expensive on some systems and we can expect better performance with file reads when GDS is used, especially with compatibility mode.This PR adds a source type that does not use
mmapfor host reads. This type is used when GDS and its compatibility mode are enabled.file_sourceis now a base class for file-based input and only implements the device_read functions.memory_mapped_sourceclass implements the host reads through the memory mapped file.direct_read_sourceis a newly implemented class that uses read for host reads, nommap.Selection is done in
datasource::createbased oncufile_config.