Fix dictionary size computation in ORC writer - #7737
Merged
rapids-bot[bot] merged 1 commit intoMar 27, 2021
Conversation
Contributor
Fixes #7661 |
vuule
marked this pull request as ready for review
March 27, 2021 00:34
kaatish
approved these changes
Mar 27, 2021
Contributor
Author
|
rerun tests |
ramakrishnap-nv
approved these changes
Mar 27, 2021
Codecov Report
@@ Coverage Diff @@
## branch-0.19 #7737 +/- ##
===============================================
+ Coverage 81.86% 82.52% +0.65%
===============================================
Files 101 101
Lines 16884 17458 +574
===============================================
+ Hits 13822 14407 +585
+ Misses 3062 3051 -11
Continue to review full report at Codecov.
|
Contributor
Author
|
@gpucibot merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7661
Corrects the field order in
std::accumulatethat computes the string column size w.r.t encoding.