Skip to content

Add replacements column support for Java replaceNulls [skip ci] - #7750

Merged
rapids-bot[bot] merged 2 commits into
NVIDIA:branch-0.19from
jlowe:jni-replacenulls
Mar 29, 2021
Merged

Add replacements column support for Java replaceNulls [skip ci]#7750
rapids-bot[bot] merged 2 commits into
NVIDIA:branch-0.19from
jlowe:jni-replacenulls

Conversation

@jlowe

@jlowe jlowe commented Mar 29, 2021

Copy link
Copy Markdown
Contributor

Adds Java bindings for cudf::replace_nulls with a columnar replacement parameter.

@jlowe jlowe added 3 - Ready for Review Ready for review by team Java Affects Java cuDF API. 4 - Needs cuDF (Java) Reviewer improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Mar 29, 2021
@jlowe jlowe self-assigned this Mar 29, 2021
@jlowe
jlowe requested a review from a team as a code owner March 29, 2021 13:43
@codecov

codecov Bot commented Mar 29, 2021

Copy link
Copy Markdown

Codecov Report

Merging #7750 (fa1e294) into branch-0.19 (ccc28d5) will increase coverage by 0.38%.
The diff coverage is n/a.

❗ Current head fa1e294 differs from pull request most recent head a3fdbd6. Consider uploading reports for the commit a3fdbd6 to get more accurate results
Impacted file tree graph

@@               Coverage Diff               @@
##           branch-0.19    #7750      +/-   ##
===============================================
+ Coverage        82.13%   82.52%   +0.38%     
===============================================
  Files              101      101              
  Lines            17096    17458     +362     
===============================================
+ Hits             14042    14407     +365     
+ Misses            3054     3051       -3     
Impacted Files Coverage Δ
python/cudf/cudf/utils/gpu_utils.py 53.65% <0.00%> (-4.88%) ⬇️
python/cudf/cudf/core/abc.py 87.23% <0.00%> (-1.14%) ⬇️
python/cudf/cudf/io/feather.py 100.00% <0.00%> (ø)
python/cudf/cudf/comm/serialize.py 0.00% <0.00%> (ø)
python/cudf/cudf/_fuzz_testing/io.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/column/struct.py 100.00% <0.00%> (ø)
python/dask_cudf/dask_cudf/_version.py 0.00% <0.00%> (ø)
python/cudf/cudf/_fuzz_testing/fuzzer.py 0.00% <0.00%> (ø)
python/cudf/cudf/utils/hash_vocab_utils.py 100.00% <0.00%> (ø)
python/dask_cudf/dask_cudf/io/tests/test_csv.py 100.00% <0.00%> (ø)
... and 40 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ccc28d5...a3fdbd6. Read the comment docs.

@revans2 revans2 changed the title Add replacements column support for Java replaceNulls Add replacements column support for Java replaceNulls [skip ci] Mar 29, 2021
@jlowe

jlowe commented Mar 29, 2021

Copy link
Copy Markdown
Contributor Author

rerun tests

@jlowe

jlowe commented Mar 29, 2021

Copy link
Copy Markdown
Contributor Author

@gpucibot merge

@rapids-bot
rapids-bot Bot merged commit cddafd9 into NVIDIA:branch-0.19 Mar 29, 2021
@jlowe
jlowe deleted the jni-replacenulls branch March 29, 2021 17:35
@vyasr vyasr added 4 - Needs Review Waiting for reviewer to review or respond and removed 4 - Needs cuDF (Java) Reviewer labels Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3 - Ready for Review Ready for review by team 4 - Needs Review Waiting for reviewer to review or respond improvement Improvement / enhancement to an existing function Java Affects Java cuDF API. non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants