Skip to content

Push DeviceScalar construction into cython for list.contains - #7864

Merged
rapids-bot[bot] merged 5 commits into
NVIDIA:branch-0.19from
brandon-b-miller:7854-fix-list-contains-scalar
Apr 6, 2021
Merged

Push DeviceScalar construction into cython for list.contains#7864
rapids-bot[bot] merged 5 commits into
NVIDIA:branch-0.19from
brandon-b-miller:7854-fix-list-contains-scalar

Conversation

@brandon-b-miller

Copy link
Copy Markdown
Contributor

Fixes #7854.

@brandon-b-miller
brandon-b-miller requested a review from a team as a code owner April 5, 2021 22:06
@github-actions github-actions Bot added the Python Affects Python cuDF API. label Apr 5, 2021
@brandon-b-miller brandon-b-miller added 3 - Ready for Review Ready for review by team bug Something isn't working Cython non-breaking Non-breaking change labels Apr 5, 2021
@kkraus14 kkraus14 added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team labels Apr 5, 2021
@kkraus14

kkraus14 commented Apr 5, 2021

Copy link
Copy Markdown
Contributor

@gpucibot merge

Comment thread python/cudf/cudf/tests/test_contains.py Outdated
@codecov

codecov Bot commented Apr 6, 2021

Copy link
Copy Markdown

Codecov Report

Merging #7864 (a68b446) into branch-0.19 (7871e7a) will increase coverage by 0.88%.
The diff coverage is n/a.

❗ Current head a68b446 differs from pull request most recent head de1a1c7. Consider uploading reports for the commit de1a1c7 to get more accurate results
Impacted file tree graph

@@               Coverage Diff               @@
##           branch-0.19    #7864      +/-   ##
===============================================
+ Coverage        81.86%   82.74%   +0.88%     
===============================================
  Files              101      103       +2     
  Lines            16884    17701     +817     
===============================================
+ Hits             13822    14647     +825     
+ Misses            3062     3054       -8     
Impacted Files Coverage Δ
python/cudf/cudf/utils/dtypes.py 83.44% <0.00%> (-6.08%) ⬇️
python/cudf/cudf/core/column/lists.py 87.41% <0.00%> (-3.99%) ⬇️
python/cudf/cudf/core/column/decimal.py 92.92% <0.00%> (-1.95%) ⬇️
python/cudf/cudf/core/groupby/groupby.py 92.41% <0.00%> (-1.04%) ⬇️
python/cudf/cudf/utils/utils.py 85.36% <0.00%> (-0.07%) ⬇️
python/dask_cudf/dask_cudf/backends.py 89.58% <0.00%> (-0.05%) ⬇️
python/cudf/cudf/__init__.py 100.00% <0.00%> (ø)
python/cudf/cudf/io/feather.py 100.00% <0.00%> (ø)
python/cudf/cudf/core/__init__.py 100.00% <0.00%> (ø)
python/cudf/cudf/utils/ioutils.py 78.71% <0.00%> (ø)
... and 48 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9f1789...de1a1c7. Read the comment docs.

@rapids-bot
rapids-bot Bot merged commit c8c00f1 into NVIDIA:branch-0.19 Apr 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

5 - Ready to Merge Testing and reviews complete, ready to merge bug Something isn't working non-breaking Non-breaking change Python Affects Python cuDF API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] list contains requires passing a device scalar

3 participants