Groupby.shift c++ API refactor and python binding - #8131
Conversation
Codecov Report
@@ Coverage Diff @@
## branch-21.06 #8131 +/- ##
===============================================
Coverage ? 82.88%
===============================================
Files ? 105
Lines ? 17888
Branches ? 0
===============================================
Hits ? 14826
Misses ? 3062
Partials ? 0 Continue to review full report at Codecov.
|
Co-authored-by: GALI PREM SAGAR <sagarprem75@gmail.com>
Co-authored-by: Christopher Harris <xixonia@gmail.com>
…roupshift-python
…groupshift-python
|
Failed tests should be fixed by #8272 |
There was a problem hiding this comment.
should we change this index in the test, or should we be returning the same order as pandas in the public api?
There was a problem hiding this comment.
Currently groupby.agg already diverts from pandas in row orders, in that cudf does not alter the key order returned from libcudf to match pandas order. Here we follow the same convention.
|
@gpucibot merge |
|
rerun tests |
2 similar comments
|
rerun tests |
|
rerun tests |
|
@gpucibot merge |
|
rerun tests |
Closes #7183 , follow up of #7910
This PR:
groupby::shiftAPI, which only takes a single column, to accept multiple columns.groupby.shift. Example python usage:Minor refactors:
use_threadparameter todataset_generator.rand_dataframeto expose thread pool config.