Add Java API for Concatenate strings with separator [skip ci] - #8289
Merged
Conversation
Signed-off-by: Thomas Graves <tgraves@nvidia.com>
Signed-off-by: Thomas Graves <tgraves@nvidia.com>
Signed-off-by: Thomas Graves <tgraves@nvidia.com>
Signed-off-by: Thomas Graves <tgraves@nvidia.com>
Signed-off-by: Thomas Graves <tgraves@nvidia.com>
Signed-off-by: Thomas Graves <tgraves@nvidia.com>
Signed-off-by: Thomas Graves <tgraves@nvidia.com>
…list concatenate with scalar separator
Signed-off-by: Thomas Graves <tgraves@nvidia.com>
This reverts commit 93fba2a.
tgravescs
added
feature request
jlowe
reviewed
May 19, 2021
jlowe
marked this pull request as draft
May 19, 2021 23:00
Contributor
revans2
approved these changes
May 20, 2021
jlowe
reviewed
May 20, 2021
jlowe
reviewed
May 20, 2021
jlowe
approved these changes
May 20, 2021
jlowe
left a comment
jlowe
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me other than a minor nit about the parameter naming.
jlowe
approved these changes
May 20, 2021
Contributor
Author
|
Note the last commit I pushed, if need be I can separate that out into another PR if 8285 doesn't get in quick enough. |
This was referenced May 21, 2021
revans2
approved these changes
May 24, 2021
Contributor
Author
|
note the last test fix is put up in https://github.com/rapidsai/cudf/pull/8330/files |
Contributor
Author
|
The Prs this was depending on are all merged marking as ready for review. I'm also asynchronously upmerging and running tests once more. |
tgravescs
marked this pull request as ready for review
May 26, 2021 20:48
Contributor
Author
|
@gpucibot merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add java api's to be able to call string concatenate with separators.
DO NOT MERGE until: #8285 and #8282 are merged. We need those changes for the API used in this PR as well as functionality to match what Spark needs.
new arguments were added to the existing concatenate api that takes a scalar for the separator, so I extended that. I added new api's for the concatenate api that takes a column as the separator. I also added new api's for both join_list_elements api's, one with scalar separator and one with column separator.