fix minor ASAN issues in UMAPAlgo::Optimize::find_params_ab() - #4405
Merged
rapids-bot[bot] merged 2 commits intoDec 6, 2021
Merged
Conversation
Contributor
|
Can one of the admins verify this patch? |
Signed-off-by: Yitao Li <yitao@rstudio.com>
yitao-li
force-pushed
the
bugfix/umap-find-params-ab-asan-issue
branch
from
November 24, 2021 18:09
499bb3b to
3106f80
Compare
Collaborator
|
ok to test |
1 similar comment
Collaborator
|
ok to test |
Signed-off-by: Yitao Li <yitao@rstudio.com>
Collaborator
|
rerun tests |
2 similar comments
Collaborator
|
rerun tests |
Collaborator
|
rerun tests |
cjnolet
approved these changes
Dec 6, 2021
cjnolet
left a comment
cjnolet
left a comment
Collaborator
There was a problem hiding this comment.
LGTM. Thanks for the contribution!
Collaborator
|
@gpucibot merge |
vimarsh6739
pushed a commit
to vimarsh6739/cuml
that referenced
this pull request
Oct 9, 2023
…#4405) There were actuall 2 minor issues that prevented `UMAPAlgo::Optimize::find_params_ab()` from being ASAN-clean at the moment: - One is the mem leaks, of course - Another one is the `malloc()`-`delete` mismatch -- only memory allocated using `new` or equivalent should be freed with operator `delete` or `delete[]` Another issue that was also addressed here: exception safety (i.e., by using `make_unique` from C++-14) Signed-off-by: Yitao Li <yitao@rstudio.com> Authors: - Yitao Li (https://github.com/yitao-li) Approvers: - Zach Bjornson (https://github.com/zbjornson) - Corey J. Nolet (https://github.com/cjnolet) URL: NVIDIA#4405
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## branch-22.02 #4405 +/- ##
===============================================
Coverage ? 85.83%
===============================================
Files ? 236
Lines ? 19410
Branches ? 0
===============================================
Hits ? 16660
Misses ? 2750
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There were actuall 2 minor issues that prevented
UMAPAlgo::Optimize::find_params_ab()from being ASAN-clean at the moment:malloc()-deletemismatch -- only memory allocated usingnewor equivalent should be freed with operatordeleteordelete[]Another issue that was also addressed here: exception safety (i.e., by using
make_uniquefrom C++-14)Signed-off-by: Yitao Li yitao@rstudio.com