remove faiss from cuml - #5293
Merged
Merged
Conversation
Co-authored-by: Dante Gama Dessavre <dante.gamadessavre@gmail.com>
Remove faiss from cuml, by changing the mutual reachability code to use the new tiled_brute_force_knn code in RAFT - instead of using faiss calls
github-actions
Bot
added
ci
CMake
conda
ajschmidt8
approved these changes
Mar 22, 2023
ajschmidt8
left a comment
ajschmidt8
left a comment
Member
There was a problem hiding this comment.
Approving ops-codeowner file changes
cjnolet
reviewed
Mar 23, 2023
| // or __host__ __device__ lambda` | ||
| auto post_process = ReachabilityPostProcess<value_t>{handle, core_dists, alpha}; | ||
|
|
||
| raft::neighbors::detail::tiled_brute_force_knn(handle, |
Collaborator
There was a problem hiding this comment.
We can even set an identity_op for the default epilogue setting here just so we instantiate that by default.
cjnolet
requested changes
Mar 25, 2023
cjnolet
left a comment
cjnolet
left a comment
Collaborator
There was a problem hiding this comment.
Looks great! Very minor things as usual.
| and profiling enabled (WARNING: Impacts performance) | ||
| --ccache - Use ccache to cache previous compilations | ||
| --nocloneraft - CMake will clone RAFT even if it is in the environment, use this flag to disable that behavior | ||
| --static-faiss - Force CMake to use the FAISS static libs, cloning and building them if necessary |
cjnolet
added
improvement
rapids-bot Bot
pushed a commit
to NVIDIA/raft
that referenced
this pull request
Mar 28, 2023
Add the ability for a user to specify an epilogue function to run after the distance in the brute_force::knn call. This lets us remove faiss from cuml, by updating the hdbscan reachability code (NVIDIA/cuml#5293) Authors: - Ben Frederickson (https://github.com/benfred) - Corey J. Nolet (https://github.com/cjnolet) Approvers: - Corey J. Nolet (https://github.com/cjnolet) URL: #1371
cjnolet
approved these changes
Mar 28, 2023
Collaborator
|
/merge |
loulankxh
pushed a commit
to loulankxh/raft
that referenced
this pull request
Oct 14, 2025
Add the ability for a user to specify an epilogue function to run after the distance in the brute_force::knn call. This lets us remove faiss from cuml, by updating the hdbscan reachability code (NVIDIA/cuml#5293) Authors: - Ben Frederickson (https://github.com/benfred) - Corey J. Nolet (https://github.com/cjnolet) Approvers: - Corey J. Nolet (https://github.com/cjnolet) URL: NVIDIA#1371
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove faiss from cuml, by changing the mutual reachability code to use the new
tiled_brute_force_knn code in RAFT - instead of using faiss calls