Remove PoolMemoryResource wrapper - #7878
Merged
Merged
Conversation
I'm seeing some OOMs in CI after the `PoolMemoryResource` was added. Trying removing it to see if that fixes it.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughSummary by CodeRabbit
WalkthroughSimplified memory resource configuration in CUML's acceleration core by removing an intermediate PoolMemoryResource layer from the PrefetchResourceAdaptor construction and streamlining associated type checks. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan for PR comments
Comment |
bdice
approved these changes
Mar 12, 2026
Member
Author
|
/merge |
jcrist
added a commit
to jcrist/cuml
that referenced
this pull request
Mar 12, 2026
I'm seeing some OOMs in CI after the `PoolMemoryResource` was added. Trying removing it to see if that fixes it. Authors: - Jim Crist-Harif (https://github.com/jcrist) Approvers: - Bradley Dice (https://github.com/bdice) URL: NVIDIA#7878
rapids-bot Bot
pushed a commit
that referenced
this pull request
Mar 12, 2026
Cherry-pick of #7878 into the release branch for 26.04. Authors: - Jim Crist-Harif (https://github.com/jcrist) Approvers: - Simon Adorf (https://github.com/csadorf) URL: #7881
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm seeing some OOMs in CI after the
PoolMemoryResourcewas added. Trying removing it to see if that fixes it.