fix more verify-hardcoded-version findings - #7891
Conversation
| warnings.warn( | ||
| "cuml is adding support for `feature_names_in_` for validating " | ||
| "the feature names of dataframe-like inputs. In cuml 26.06 this " | ||
| "the feature names of dataframe-like inputs. In version 26.06 of cuML this " |
There was a problem hiding this comment.
This rewording hits one of the heuristics the linter uses to detect false positives: rapidsai/pre-commit-hooks#112
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughSummary by CodeRabbitRelease Notes
WalkthroughTwo minor updates: the Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Comment |
|
These aren't failing on the 26.04 branch but are failing on main - is the pre-commit check different between these branches? |
|
The check looks at the |
|
Since our version strings are a fixed format, could we update the check to look for more than just the current version? Our deprecation warnings usually include the current release version as well as the upcoming one. This would help avoid merging in code that won't cause pre-commit failures until the version is bumped. Just a suggestion. |
|
That's not a bad idea. I can have it look at the previous and next minor versions for cases like ucxx, and the previous and next calver versions for the rest of RAPIDS. I'll add it to the list. |
|
Admin-merging this, the failures are unrelated (I think they're caused by not having new nightlies for all packages yet). |
Similar to #7882
Fixes new
verify-hardcoded-versionfindings onmain