chore: bump codespell version for Python 3.14+ compatibility - #7925
Conversation
📝 WalkthroughSummary by CodeRabbit
WalkthroughMinor non-functional edits across the repo: pre-commit/tooling configuration updates, SPDX year bumps, and numerous comment/docstring/markdown typo fixes; one test variable rename in Python tests. No API, signature, logic, or behavior changes. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Suggested reviewers
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
Looks like many spelling errors need to be fixed. |
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
We'll want to ignore the typo fix commit in |
I vote add in a follow-up and admin-merge that followup to save CI resources. Just in case this PR gets stuck because of some other CI failure and you end up needing to add merge commits to pull in latest |
These changes don't seem significant enough to warrant that in my opinion. Typically we only consider that for massive formatting changes (thousands of lines, not +42/-42). |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@python/cuml/tests/test_hdbscan.py`:
- Line 468: In test_hdbscan_empty_cluster_tree replace the unused unpacked
variable by either using a throwaway name or asserting it: change the unpack
from "labels, probabilities = _extract_clusters(" to "labels, _ =
_extract_clusters(" (or add an explicit assertion on probabilities) so the
unused value no longer triggers RUF059; locate the unpack in the
test_hdbscan_empty_cluster_tree function where _extract_clusters is called and
update the second target as described.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 9b71455b-d467-4885-9945-3e9eda485600
📒 Files selected for processing (19)
cpp/include/cuml/explainer/kernel_shap.hppcpp/include/cuml/genetic/program.hcpp/include/cuml/solvers/lars.hppcpp/include/cuml/svm/svm_api.hcpp/src/decisiontree/batched-levelalgo/kernels/builder_kernels.cuhcpp/src/explainer/kernel_shap.cucpp/src/solver/lars_impl.cuhcpp/src/svm/smoblocksolve.cuhcpp/src/umap/fuzzy_simpl_set/naive.cuhcpp/src_prims/common/device_utils.cuhcpp/tests/sg/dbscan_test.cudocs/source/cuml-accel/faq.rstnotebooks/target_encoder_walkthrough.ipynbpyproject.tomlpython/cuml/cuml/dask/common/base.pypython/cuml/cuml/dask/common/func.pypython/cuml/cuml/internals/mixins.pypython/cuml/tests/test_hdbscan.pywiki/python/ESTIMATOR_GUIDE.md
✅ Files skipped from review due to trivial changes (18)
- python/cuml/cuml/dask/common/func.py
- notebooks/target_encoder_walkthrough.ipynb
- cpp/src/decisiontree/batched-levelalgo/kernels/builder_kernels.cuh
- cpp/src/explainer/kernel_shap.cu
- cpp/src_prims/common/device_utils.cuh
- cpp/src/svm/smoblocksolve.cuh
- wiki/python/ESTIMATOR_GUIDE.md
- docs/source/cuml-accel/faq.rst
- cpp/include/cuml/svm/svm_api.h
- cpp/include/cuml/solvers/lars.hpp
- cpp/tests/sg/dbscan_test.cu
- cpp/include/cuml/genetic/program.h
- cpp/include/cuml/explainer/kernel_shap.hpp
- python/cuml/cuml/internals/mixins.py
- python/cuml/cuml/dask/common/base.py
- cpp/src/solver/lars_impl.cuh
- pyproject.toml
- cpp/src/umap/fuzzy_simpl_set/naive.cuh
|
/merge |
Description
xref rapidsai/build-planning#205
xref rapidsai/build-planning#152
Python 3.14 brings with it newer versions of
setuptoolsthat areincompatible with older license formats in
pyproject.toml. We fixed thisfor RAPIDS in rapidsai/build-planning#152.
codespellneeds to be bumpedto version 2.4.1 to be compatible with newer setuptools.