Skip to content

chore: bump codespell version for Python 3.14+ compatibility - #7925

Merged
rapids-bot[bot] merged 3 commits into
NVIDIA:mainfrom
gforsyth:bump_codespell
Apr 6, 2026
Merged

chore: bump codespell version for Python 3.14+ compatibility#7925
rapids-bot[bot] merged 3 commits into
NVIDIA:mainfrom
gforsyth:bump_codespell

Conversation

@gforsyth

Copy link
Copy Markdown
Contributor

Description

xref rapidsai/build-planning#205
xref rapidsai/build-planning#152

Python 3.14 brings with it newer versions of setuptools that are
incompatible with older license formats in pyproject.toml. We fixed this
for RAPIDS in rapidsai/build-planning#152. codespell needs to be bumped
to version 2.4.1 to be compatible with newer setuptools.

@gforsyth
gforsyth requested a review from a team as a code owner March 23, 2026 19:53
@gforsyth
gforsyth requested a review from bdice March 23, 2026 19:53
@gforsyth gforsyth added non-breaking Non-breaking change improvement Improvement / enhancement to an existing function labels Mar 23, 2026
@coderabbitai

coderabbitai Bot commented Mar 23, 2026

Copy link
Copy Markdown
📝 Walkthrough

Summary by CodeRabbit

  • Chores
    • Updated pre-commit tooling configuration (codespell) and ignore-list; updated SPDX copyright year ranges across the project.
  • Documentation
    • Fixed numerous spelling/typo issues in docs, docstrings, comments, notebooks, and the wiki for clearer wording.
  • Tests
    • Corrected test variable name typos to improve test clarity.

Walkthrough

Minor non-functional edits across the repo: pre-commit/tooling configuration updates, SPDX year bumps, and numerous comment/docstring/markdown typo fixes; one test variable rename in Python tests. No API, signature, logic, or behavior changes.

Changes

Cohort / File(s) Summary
Tooling / Config
\.pre-commit-config.yaml, pyproject.toml
Updated codespell pre-commit hook revision to v2.4.1 and extended codespell ignore-words-list; no other hook settings changed. SPDX year in pyproject.toml updated.
C++ headers & sources (SPDX + comments)
cpp/include/.../kernel_shap.hpp, cpp/include/.../program.h, cpp/include/.../lars.hpp, cpp/include/.../svm/svm_api.h, cpp/src/.../kernel_shap.cu, cpp/src/.../lars_impl.cuh, cpp/src/.../smoblocksolve.cuh, cpp/src/.../builder_kernels.cuh, cpp/src/umap/.../naive.cuh, cpp/src_prims/.../device_utils.cuh
Bumped SPDX years and fixed multiple typos/wording in comments and Doxygen strings. No changes to function signatures or implementation logic.
C++ tests
cpp/tests/sg/dbscan_test.cu
SPDX year update and corrected inline comment spellings only.
Python code & tests
python/cuml/.../base.py, python/cuml/.../func.py, python/cuml/.../mixins.py, python/cuml/tests/test_hdbscan.py
SPDX year updates, docstring/comment typo fixes; in tests renamed local variable probabiltiesprobabilities and updated assertions. No public API changes.
Docs, notebooks, wiki
docs/source/cuml-accel/faq.rst, notebooks/target_encoder_walkthrough.ipynb, wiki/python/ESTIMATOR_GUIDE.md
Corrected typos/duplicated words in documentation and notebook markdown. No content structure changes.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Suggested reviewers

  • dantegd
  • csadorf
🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 62.50% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: bumping codespell version for Python 3.14+ compatibility, which is supported by .pre-commit-config.yaml and pyproject.toml modifications.
Description check ✅ Passed The description is directly related to the changeset, explaining the motivation (Python 3.14 setuptools incompatibility) and the solution (bump codespell to v2.4.1) with relevant issue references.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@tarang-jain

Copy link
Copy Markdown
Contributor

Looks like many spelling errors need to be fixed.

@gforsyth
gforsyth requested review from a team as code owners March 24, 2026 14:17
@review-notebook-app

Copy link
Copy Markdown

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@github-actions github-actions Bot added Cython / Python Cython or Python issue CUDA/C++ labels Mar 24, 2026
@gforsyth

Copy link
Copy Markdown
Contributor Author

We'll want to ignore the typo fix commit in .git-blame-ignore-revs -- we can either merge this and add the commit in a follow-up, or I can add it now and we could /merge nosquash to preserve the commit sha.

@jameslamb

Copy link
Copy Markdown
Member

we can either merge this and add the commit in a follow-up

I vote add in a follow-up and admin-merge that followup to save CI resources.

Just in case this PR gets stuck because of some other CI failure and you end up needing to add merge commits to pull in latest main.

@gforsyth
gforsyth removed the request for review from bdice March 24, 2026 15:27
@bdice

bdice commented Apr 1, 2026

Copy link
Copy Markdown
Contributor

We'll want to ignore the typo fix commit in .git-blame-ignore-revs

These changes don't seem significant enough to warrant that in my opinion. Typically we only consider that for massive formatting changes (thousands of lines, not +42/-42).

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@python/cuml/tests/test_hdbscan.py`:
- Line 468: In test_hdbscan_empty_cluster_tree replace the unused unpacked
variable by either using a throwaway name or asserting it: change the unpack
from "labels, probabilities = _extract_clusters(" to "labels, _ =
_extract_clusters(" (or add an explicit assertion on probabilities) so the
unused value no longer triggers RUF059; locate the unpack in the
test_hdbscan_empty_cluster_tree function where _extract_clusters is called and
update the second target as described.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 9b71455b-d467-4885-9945-3e9eda485600

📥 Commits

Reviewing files that changed from the base of the PR and between 20dc810 and b8b3a5a.

📒 Files selected for processing (19)
  • cpp/include/cuml/explainer/kernel_shap.hpp
  • cpp/include/cuml/genetic/program.h
  • cpp/include/cuml/solvers/lars.hpp
  • cpp/include/cuml/svm/svm_api.h
  • cpp/src/decisiontree/batched-levelalgo/kernels/builder_kernels.cuh
  • cpp/src/explainer/kernel_shap.cu
  • cpp/src/solver/lars_impl.cuh
  • cpp/src/svm/smoblocksolve.cuh
  • cpp/src/umap/fuzzy_simpl_set/naive.cuh
  • cpp/src_prims/common/device_utils.cuh
  • cpp/tests/sg/dbscan_test.cu
  • docs/source/cuml-accel/faq.rst
  • notebooks/target_encoder_walkthrough.ipynb
  • pyproject.toml
  • python/cuml/cuml/dask/common/base.py
  • python/cuml/cuml/dask/common/func.py
  • python/cuml/cuml/internals/mixins.py
  • python/cuml/tests/test_hdbscan.py
  • wiki/python/ESTIMATOR_GUIDE.md
✅ Files skipped from review due to trivial changes (18)
  • python/cuml/cuml/dask/common/func.py
  • notebooks/target_encoder_walkthrough.ipynb
  • cpp/src/decisiontree/batched-levelalgo/kernels/builder_kernels.cuh
  • cpp/src/explainer/kernel_shap.cu
  • cpp/src_prims/common/device_utils.cuh
  • cpp/src/svm/smoblocksolve.cuh
  • wiki/python/ESTIMATOR_GUIDE.md
  • docs/source/cuml-accel/faq.rst
  • cpp/include/cuml/svm/svm_api.h
  • cpp/include/cuml/solvers/lars.hpp
  • cpp/tests/sg/dbscan_test.cu
  • cpp/include/cuml/genetic/program.h
  • cpp/include/cuml/explainer/kernel_shap.hpp
  • python/cuml/cuml/internals/mixins.py
  • python/cuml/cuml/dask/common/base.py
  • cpp/src/solver/lars_impl.cuh
  • pyproject.toml
  • cpp/src/umap/fuzzy_simpl_set/naive.cuh

Comment thread python/cuml/tests/test_hdbscan.py
@gforsyth

gforsyth commented Apr 6, 2026

Copy link
Copy Markdown
Contributor Author

/merge

@rapids-bot
rapids-bot Bot merged commit 6d79ba6 into NVIDIA:main Apr 6, 2026
101 checks passed
@gforsyth
gforsyth deleted the bump_codespell branch April 6, 2026 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CUDA/C++ Cython / Python Cython or Python issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants