Build and test with CUDA 13.2.0 - #8081
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
📝 WalkthroughSummary by CodeRabbit
WalkthroughThis PR upgrades the repository's CUDA toolchain support from version 13.1 to 13.2. Changes span CI/CD matrices, conda environment definitions, development containers, GitHub Actions workflow pinning, and developer documentation. ChangesCUDA 13.2 Upgrade
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@CONTRIBUTING.md`:
- Line 147: The conda env creation command uses $(uname -m) which can resolve to
a non-existent aarch64 YAML (the clang-tidy env matrix is x86_64-only); update
the instruction around the command `conda env create --yes -n cuml-clang-tidy -f
conda/environments/clang_tidy_cuda-132_arch-$(uname -m).yaml` to either hardcode
the x86_64 filename or add an explicit note/guard that users on non-x86_64 must
use the x86_64 YAML (e.g., replace $(uname -m) with x86_64 or document to set
ARCH=x86_64), so the referenced conda env file always exists for clang-tidy.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: a7c1b96a-794b-4719-913c-f474859f9e23
📒 Files selected for processing (14)
.devcontainer/cuda13.2-conda/devcontainer.json.devcontainer/cuda13.2-pip/devcontainer.json.github/workflows/build.yaml.github/workflows/pr.yaml.github/workflows/pr_issue_status_automation.yml.github/workflows/test.yaml.github/workflows/trigger-breaking-change-alert.yamlBUILD.mdCONTRIBUTING.mdconda/environments/all_cuda-132_arch-aarch64.yamlconda/environments/all_cuda-132_arch-x86_64.yamlconda/environments/clang_tidy_cuda-132_arch-x86_64.yamlconda/environments/cpp_all_cuda-132_arch-x86_64.yamldependencies.yaml
|
/merge |
Contributes to rapidsai/build-planning#265
Notes for Reviewers
This switches GitHub Actions workflows to the
cuda-13.2.0branch from here: rapidsai/shared-workflows#545A future round of PRs will revert that back to
main, once all of RAPIDS is migrated.