Skip to content

Require CMake 4.0 - #8096

Merged
rapids-bot[bot] merged 3 commits into
NVIDIA:mainfrom
KyleFromNVIDIA:cmake-4.0
May 14, 2026
Merged

Require CMake 4.0#8096
rapids-bot[bot] merged 3 commits into
NVIDIA:mainfrom
KyleFromNVIDIA:cmake-4.0

Conversation

@KyleFromNVIDIA

Copy link
Copy Markdown
Member

@KyleFromNVIDIA
KyleFromNVIDIA requested review from a team as code owners May 13, 2026 15:52
@KyleFromNVIDIA
KyleFromNVIDIA requested review from bdice, csadorf and vyasr May 13, 2026 15:52
@github-actions github-actions Bot added conda conda issue Cython / Python Cython or Python issue CMake CUDA/C++ labels May 13, 2026
@coderabbitai

coderabbitai Bot commented May 13, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 60e40649-0ea6-42b7-8fc5-48bbaa12407c

📥 Commits

Reviewing files that changed from the base of the PR and between 9584f34 and d298fd2.

📒 Files selected for processing (19)
  • BUILD.md
  • cmake/RAPIDS.cmake
  • conda/environments/all_cuda-129_arch-aarch64.yaml
  • conda/environments/all_cuda-129_arch-x86_64.yaml
  • conda/environments/all_cuda-132_arch-aarch64.yaml
  • conda/environments/all_cuda-132_arch-x86_64.yaml
  • conda/environments/clang_tidy_cuda-129_arch-x86_64.yaml
  • conda/environments/clang_tidy_cuda-132_arch-x86_64.yaml
  • conda/environments/cpp_all_cuda-129_arch-x86_64.yaml
  • conda/environments/cpp_all_cuda-132_arch-x86_64.yaml
  • conda/recipes/cuml/conda_build_config.yaml
  • conda/recipes/libcuml/conda_build_config.yaml
  • cpp/CMakeLists.txt
  • dependencies.yaml
  • python/cuml/CMakeLists.txt
  • python/cuml/README.md
  • python/cuml/pyproject.toml
  • python/libcuml/CMakeLists.txt
  • python/libcuml/pyproject.toml

📝 Walkthrough

Summary by CodeRabbit

  • Chores
    • Updated minimum required CMake version to 4.0 across all build and environment configurations.

Walkthrough

This PR uniformly updates the minimum CMake version requirement from 3.30.4 to 4.0 across build configurations, dependency definitions, conda environments, and documentation throughout the cuML repository.

Changes

CMake 4.0 Requirement Update

Layer / File(s) Summary
Core CMake minimum version requirements
cmake/RAPIDS.cmake, cpp/CMakeLists.txt, python/cuml/CMakeLists.txt, python/libcuml/CMakeLists.txt
CMake minimum required version is bumped to 4.0 in the RAPIDS cmake module and all CMakeLists.txt entry points.
Central dependency version definition
dependencies.yaml
The shared CMake version anchor is updated to 4.0, affecting downstream conda environment generation and build system configuration.
Build backend and recipe configuration
conda/recipes/cuml/conda_build_config.yaml, conda/recipes/libcuml/conda_build_config.yaml, python/cuml/pyproject.toml, python/libcuml/pyproject.toml
Conda build config files and Python build backend requirements are updated to require CMake 4.0.
Generated environments and documentation
conda/environments/all_cuda-129_arch-aarch64.yaml, conda/environments/all_cuda-129_arch-x86_64.yaml, conda/environments/all_cuda-132_arch-aarch64.yaml, conda/environments/all_cuda-132_arch-x86_64.yaml, conda/environments/clang_tidy_cuda-129_arch-x86_64.yaml, conda/environments/clang_tidy_cuda-132_arch-x86_64.yaml, conda/environments/cpp_all_cuda-129_arch-x86_64.yaml, conda/environments/cpp_all_cuda-132_arch-x86_64.yaml, BUILD.md, python/cuml/README.md
All conda environment definitions and build documentation are updated to reflect the CMake 4.0 requirement.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Suggested labels

improvement, non-breaking

Suggested reviewers

  • bdice
  • vyasr
  • csadorf
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Require CMake 4.0' clearly and directly summarizes the main change: updating the CMake minimum version requirement from 3.30.4 to 4.0 across the entire codebase.
Description check ✅ Passed The description provides a reference to the related issue (#277) that motivated this change, which is relevant to understanding the context and rationale for the CMake version bump.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@KyleFromNVIDIA KyleFromNVIDIA added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels May 14, 2026
@KyleFromNVIDIA

Copy link
Copy Markdown
Member Author

/merge

@rapids-bot
rapids-bot Bot merged commit f9d55b1 into NVIDIA:main May 14, 2026
189 of 191 checks passed
@coderabbitai coderabbitai Bot mentioned this pull request Jul 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CMake conda conda issue CUDA/C++ Cython / Python Cython or Python issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants