Skip to content

Avoid deprecated functionality in cupy 14.1 - #8148

Merged
rapids-bot[bot] merged 1 commit into
NVIDIA:release/26.06from
jcrist:support-cupy-14.1
May 26, 2026
Merged

Avoid deprecated functionality in cupy 14.1#8148
rapids-bot[bot] merged 1 commit into
NVIDIA:release/26.06from
jcrist:support-cupy-14.1

Conversation

@jcrist

@jcrist jcrist commented May 26, 2026

Copy link
Copy Markdown
Member

No description provided.

@jcrist jcrist self-assigned this May 26, 2026
@jcrist
jcrist requested a review from a team as a code owner May 26, 2026 16:01
@jcrist
jcrist requested a review from viclafargue May 26, 2026 16:01
@jcrist jcrist added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels May 26, 2026
@github-actions github-actions Bot added the Cython / Python Cython or Python issue label May 26, 2026
@coderabbitai

coderabbitai Bot commented May 26, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: d2b2cba3-96b2-411e-8faf-363af90cae51

📥 Commits

Reviewing files that changed from the base of the PR and between a2d706e and 82e1795.

📒 Files selected for processing (1)
  • python/cuml/cuml/_thirdparty/sklearn/utils/sparsefuncs.py

📝 Walkthrough

Summary by CodeRabbit

Release Notes

  • Chores

    • Updated copyright year information.
  • Refactor

    • Improved sparse matrix conversion handling in min/max operations.

Walkthrough

This PR updates a scipy sparse utilities helper by fixing the sparse-to-dense array conversion method from res.A.ravel() to res.toarray().ravel() and updating the SPDX copyright header year range from 2020-2025 to 2020-2026.

Changes

Sparse utilities update

Layer / File(s) Summary
Sparse-to-dense array conversion
python/cuml/cuml/_thirdparty/sklearn/utils/sparsefuncs.py
Changed sparse result conversion method in _min_or_max_axis from res.A.ravel() to res.toarray().ravel(), and updated SPDX copyright header year range to 2020-2026.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Description check ❓ Inconclusive No pull request description was provided by the author, making it impossible to verify relevance to the changeset. Add a description explaining the deprecated cupy 14.1 functionality being addressed and why the sparse matrix conversion change was necessary.
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Avoid deprecated functionality in cupy 14.1' is directly related to the changeset, which updates SPDX headers and replaces deprecated sparse matrix conversion method.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@csadorf

csadorf commented May 26, 2026

Copy link
Copy Markdown
Contributor

/merge

@rapids-bot
rapids-bot Bot merged commit 2f2ef8d into NVIDIA:release/26.06 May 26, 2026
97 checks passed
@jcrist
jcrist deleted the support-cupy-14.1 branch May 26, 2026 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Cython / Python Cython or Python issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants