Skip to content

test routing null matrix validation#1220

Open
aycsi wants to merge 2 commits into
NVIDIA:mainfrom
aycsi:test/routing-null-matrix-validation
Open

test routing null matrix validation#1220
aycsi wants to merge 2 commits into
NVIDIA:mainfrom
aycsi:test/routing-null-matrix-validation

Conversation

@aycsi

@aycsi aycsi commented May 14, 2026

Copy link
Copy Markdown
Contributor

Description

DataModel.add_cost_matrix routes through validate_matrix, which is expected to reject matrices containing NULL values before solve-time logic. This change adds a focused negative test to lock down that contract and prevent silent regressions during future validation.

Summary

  • Add test_dist_mat_null to routing validation coverage.
  • Cover the NULL input path for cost matrices in DataModel.add_cost_matrix.

Signed-off-by: Aycsi <207523432+aycsi@users.noreply.github.com>
@aycsi
aycsi requested a review from a team as a code owner May 14, 2026 16:35
@aycsi
aycsi requested a review from tmckayus May 14, 2026 16:35
@copy-pr-bot

copy-pr-bot Bot commented May 14, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@ramakrishnap-nv
ramakrishnap-nv changed the base branch from main to release/26.06 May 20, 2026 17:31
@github-actions

Copy link
Copy Markdown

🔔 Hi @anandhkb, this pull request has had no activity for 7 days. Please update or let us know if it can be closed. Thank you!

If this is an "epic" issue, then please add the "epic" label to this issue.
If it is a PR and not ready for review, then please convert this to draft.
If you just want to switch off this notification, then use the "skip inactivity reminder" label.

7 similar comments
@github-actions

github-actions Bot commented Jun 5, 2026

Copy link
Copy Markdown

🔔 Hi @anandhkb, this pull request has had no activity for 7 days. Please update or let us know if it can be closed. Thank you!

If this is an "epic" issue, then please add the "epic" label to this issue.
If it is a PR and not ready for review, then please convert this to draft.
If you just want to switch off this notification, then use the "skip inactivity reminder" label.

@github-actions

Copy link
Copy Markdown

🔔 Hi @anandhkb, this pull request has had no activity for 7 days. Please update or let us know if it can be closed. Thank you!

If this is an "epic" issue, then please add the "epic" label to this issue.
If it is a PR and not ready for review, then please convert this to draft.
If you just want to switch off this notification, then use the "skip inactivity reminder" label.

@github-actions

Copy link
Copy Markdown

🔔 Hi @anandhkb, this pull request has had no activity for 7 days. Please update or let us know if it can be closed. Thank you!

If this is an "epic" issue, then please add the "epic" label to this issue.
If it is a PR and not ready for review, then please convert this to draft.
If you just want to switch off this notification, then use the "skip inactivity reminder" label.

@github-actions

Copy link
Copy Markdown

🔔 Hi @anandhkb, this pull request has had no activity for 7 days. Please update or let us know if it can be closed. Thank you!

If this is an "epic" issue, then please add the "epic" label to this issue.
If it is a PR and not ready for review, then please convert this to draft.
If you just want to switch off this notification, then use the "skip inactivity reminder" label.

@github-actions

github-actions Bot commented Jul 5, 2026

Copy link
Copy Markdown

🔔 Hi @anandhkb, this pull request has had no activity for 7 days. Please update or let us know if it can be closed. Thank you!

If this is an "epic" issue, then please add the "epic" label to this issue.
If it is a PR and not ready for review, then please convert this to draft.
If you just want to switch off this notification, then use the "skip inactivity reminder" label.

@github-actions

Copy link
Copy Markdown

🔔 Hi @anandhkb, this pull request has had no activity for 7 days. Please update or let us know if it can be closed. Thank you!

If this is an "epic" issue, then please add the "epic" label to this issue.
If it is a PR and not ready for review, then please convert this to draft.
If you just want to switch off this notification, then use the "skip inactivity reminder" label.

@github-actions

Copy link
Copy Markdown

🔔 Hi @anandhkb, this pull request has had no activity for 7 days. Please update or let us know if it can be closed. Thank you!

If this is an "epic" issue, then please add the "epic" label to this issue.
If it is a PR and not ready for review, then please convert this to draft.
If you just want to switch off this notification, then use the "skip inactivity reminder" label.

@ramakrishnap-nv
ramakrishnap-nv changed the base branch from release/26.06 to main July 21, 2026 15:37
@ramakrishnap-nv ramakrishnap-nv added non-breaking Introduces a non-breaking change improvement Improves an existing functionality labels Jul 21, 2026
@ramakrishnap-nv

Copy link
Copy Markdown
Collaborator

/ok to test 6d5b75a

@ramakrishnap-nv

Copy link
Copy Markdown
Collaborator

/ok to test 575b1cc

@github-actions

Copy link
Copy Markdown

CI Test Summary

✅ All 0 test job(s) passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improves an existing functionality non-breaking Introduces a non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants