Skip to content

[BUG] Fixed uninitialized FJ constraint weights when the problem grows - #1698

Merged
rapids-bot[bot] merged 2 commits into
NVIDIA:mainfrom
nguidotti:fix-fj-infinite-constraints
Aug 11, 2026
Merged

[BUG] Fixed uninitialized FJ constraint weights when the problem grows#1698
rapids-bot[bot] merged 2 commits into
NVIDIA:mainfrom
nguidotti:fix-fj-infinite-constraints

Conversation

@nguidotti

Copy link
Copy Markdown
Contributor

When the feasibility pump adds the objective cutting plane to the problem, fj.solve() resizes the constraint weights, but leave the new weights unintialized. This trips the assertion that checks for infinite (and a negative) weights in the GPU FJ. The solution is to set the new weights to 1.0, which matches copy_weights and cstr_weights fixup in do_fj_solve. Note that fj.solve() bypasses do_fj_solve.

Checklist

  • I am familiar with the Contributing Guidelines.
  • Testing
    • New or existing tests cover these changes
    • Added tests
    • Created an issue to follow-up
    • NA
  • Documentation
    • The documentation is up to date with these changes
    • Added new documentation
    • NA

Signed-off-by: Nicolas L. Guidotti <nguidotti@nvidia.com>
@nguidotti nguidotti added this to the 26.10 milestone Aug 11, 2026
@nguidotti nguidotti self-assigned this Aug 11, 2026
@nguidotti
nguidotti requested a review from a team as a code owner August 11, 2026 10:16
@nguidotti nguidotti added bug Something isn't working non-breaking Introduces a non-breaking change mip labels Aug 11, 2026
@coderabbitai

coderabbitai Bot commented Aug 11, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: fe6916ea-ec1c-466c-9b98-234a31462df7

📥 Commits

Reviewing files that changed from the base of the PR and between 6df36e2 and 1a4c4a6.

📒 Files selected for processing (1)
  • cpp/src/mip_heuristics/feasibility_jump/feasibility_jump.cu

📝 Walkthrough

Walkthrough

resize_vectors now preserves existing constraint weights and initializes newly added primary, left, and right entries to 1.0.

Changes

Feasibility jump constraint weights

Layer / File(s) Summary
Preserve and initialize constraint weights
cpp/src/mip_heuristics/feasibility_jump/feasibility_jump.cu
resize_vectors preserves existing weights during resizing and initializes new entries in the primary, left, and right arrays to 1.0.

Estimated code review effort: 2 (Simple) | ~10 minutes

Suggested reviewers: akifcorduk, aliceb-nv, rg20

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the bug and the fix for uninitialized feasibility pump constraint weights when the problem grows.
Description check ✅ Passed The description directly explains the defect, its cause, the fix, and related testing and documentation status.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@aliceb-nv aliceb-nv left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix Nicolas!

@github-actions

github-actions Bot commented Aug 11, 2026

Copy link
Copy Markdown

CI Test Summary

✅ All 31 test job(s) passed.

@coderabbitai coderabbitai Bot mentioned this pull request Aug 11, 2026
8 tasks
@coderabbitai coderabbitai Bot mentioned this pull request Aug 11, 2026
8 tasks
@nguidotti

Copy link
Copy Markdown
Contributor Author

/merge

@rapids-bot
rapids-bot Bot merged commit b7fb102 into NVIDIA:main Aug 11, 2026
180 of 185 checks passed
@nguidotti
nguidotti deleted the fix-fj-infinite-constraints branch August 11, 2026 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working mip non-breaking Introduces a non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants