[examples] Fix stale thread layout comment in wgmma_sm90.cu - #3401
Open
SriRangaTarun wants to merge 6 commits into
Open
[examples] Fix stale thread layout comment in wgmma_sm90.cu#3401SriRangaTarun wants to merge 6 commits into
SriRangaTarun wants to merge 6 commits into
Conversation
Updated the link to the documentation on printing in CuTe DSL.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #3340.
In the NT GEMM setup in
examples/cute/tutorial/hopper/wgmma_sm90.cu, thecopyAandcopyBtiled copies are both constructed fromLayout<Shape<_16,_8>>, but the trailing comments describe them asThr layout 32x4. The comments appear to be left over from an earlierthread arrangement.
The TN setup further down the same file constructs the same
Layout<Shape<_16,_8>, Stride<_8,_1>>and annotates itThr layout 16x8,which confirms the intended convention.
Change
Comment-only; updates both annotations from
32x4to16x8. No functionalchange and nothing to rebuild.
Since this is a tutorial example, the annotations are load-bearing for
readers learning to map
make_tiled_copyarguments onto thread/valuelayouts — a mismatch here is more costly than in ordinary source.