Skip to content

[FEA][Language Wrappers] Remove dataset views from language wrappers #2394

Description

@HowardHuang1

#1846 (comment)
#1846 (comment)
@tarang-jain mentioned in slack:
We should remove the explicit "view" type above and add a member to the dataset_t to designate whether it's owning (this isn't unlike Python ndarray)
We should make sure the c++ impl of the C apis is properly creating a view when needed (if the dastaset_t passed in is owning)

Follow up with @aamijar, @tarang-jain, and @divyegala

Current status is none of the language wrappers have had views removed yet except python (confirm with @tarang-jain). For other language wrappers, we need to evaluate each on a case by case basis.

Image

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions