Skip to content

Factor CAGRA graph kernels into shared translation unit - #2412

Merged
rapids-bot[bot] merged 3 commits into
NVIDIA:mainfrom
landrumb:landrumb/cagra-shared-kernels
Aug 6, 2026
Merged

Factor CAGRA graph kernels into shared translation unit#2412
rapids-bot[bot] merged 3 commits into
NVIDIA:mainfrom
landrumb:landrumb/cagra-shared-kernels

Conversation

@landrumb

@landrumb landrumb commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

The graph merge PR (#2352) uses some of the kernels defined by CAGRA, and binary size takes a hit from them not appearing in a TU where they can be shared by both CAGRA and Fastener.

@landrumb landrumb left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok to test

@divyegala divyegala left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one suggestion, thanks!

Comment thread cpp/src/neighbors/detail/cagra/graph_shared.cuh Outdated
Comment thread cpp/src/neighbors/detail/cagra/graph_shared.cuh Outdated
@divyegala divyegala added improvement Improves an existing functionality non-breaking Introduces a non-breaking change labels Aug 4, 2026
@divyegala

Copy link
Copy Markdown
Contributor

/merge

@rapids-bot
rapids-bot Bot merged commit 6001618 into NVIDIA:main Aug 6, 2026
240 of 245 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improves an existing functionality non-breaking Introduces a non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants