Align views with partial batch extents for SNMG ANN direct merge - #2441
Open
viclafargue wants to merge 1 commit into
Open
Align views with partial batch extents for SNMG ANN direct merge#2441viclafargue wants to merge 1 commit into
viclafargue wants to merge 1 commit into
Conversation
viclafargue
added
bug
divyegala
approved these changes
Aug 13, 2026
cjnolet
approved these changes
Aug 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
MERGE_ON_ROOT_RANKmode, shard results are packed using the current batch size, butknn_merge_partsreceives full-batch views and therefore usesn_rows_per_batchas the per-shard stride.When the final batch is smaller, results from ranks after the first are read from incorrect offsets, potentially merging stale data and returning incorrect neighbors.
The merge should use input and output views sized to
n_rows_of_current_batch.