fix(core): cleanup timeout on popover close#111
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Enterprise Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughTypeNativePopoverController now clears scheduled interest open/close timers when the popover transitions to closed via toggle, when handling a hide-popover command (before calling hidePopover()), and when the controller disconnects. Two tests assert that openDelay-driven opens are cancelled by hidePopover() and hide-popover command events. ChangesInterest Timeout Cancellation
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
ESLint install failed. For unrecoverable errors, disable the tool in CodeRabbit configuration. Comment |
|
Actionable comments posted: 0 |
- Added tests to ensure that the popover cancels delayed showing when it receives an 'interest' event or a 'hide-popover' command before the delay completes Signed-off-by: Cory Rylan <crylan@nvidia.com>
3bdc2a7 to
748fe7f
Compare
|
🎉 This issue has been resolved in version 0.2.1 🎉 |
Summary by CodeRabbit