Skip to content

fix(core): cleanup timeout on popover close #111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
coryrylan merged 1 commit into from
May 29, 2026
Merged

fix(core): cleanup timeout on popover close #111

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 42 additions & 0 deletions projects/core/src/internal/controllers/type-native-popover.controller.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -811,6 +811,48 @@ describe('type-popover.controller - interest invoker support', () => {
await new Promise(r => setTimeout(r, 60));
expect(element.matches(':popover-open')).toBe(false);
});

it('should cancel delayed show when the popover closes before delay completes', async () => {
element.openDelay = 50;
await elementIsStable(element);

const open = untilEvent(element, 'open');
element.showPopover();
expect(await open).toBeDefined();

const interestEvent = new Event('interest', { cancelable: true }) as Event & { source: HTMLElement };
interestEvent.source = button;
element.dispatchEvent(interestEvent);
await elementIsStable(element);

const close = untilEvent(element, 'close');
element.hidePopover();
expect(await close).toBeDefined();

await new Promise(r => setTimeout(r, 60));
expect(element.matches(':popover-open')).toBe(false);
});

it('should cancel delayed show when the popover receives hide-popover before delay completes', async () => {
element.openDelay = 50;
await elementIsStable(element);

const open = untilEvent(element, 'open');
element.showPopover();
expect(await open).toBeDefined();

const interestEvent = new Event('interest', { cancelable: true }) as Event & { source: HTMLElement };
interestEvent.source = button;
element.dispatchEvent(interestEvent);
await elementIsStable(element);

const close = untilEvent(element, 'close');
element.dispatchEvent(new CommandEvent('command', { command: 'hide-popover', source: button }));
expect(await close).toBeDefined();

await new Promise(r => setTimeout(r, 60));
expect(element.matches(':popover-open')).toBe(false);
});
});

describe('type-popover.controller - showPopover source fallback', () => {
Expand Down
8 changes: 8 additions & 0 deletions projects/core/src/internal/controllers/type-native-popover.controller.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,10 @@ export class TypeNativePopoverController<T extends NativePopover> implements Rea
setTimeout(() => this.host.hidePopover(), this.host.closeTimeout);
}

if (e.newState === 'closed') {
this.#clearInterestTimeout();
}

this.host.inert = this.host.matches(':not(:popover-open)');

if (this.host.modal) {
Expand All @@ -119,6 +123,7 @@ export class TypeNativePopoverController<T extends NativePopover> implements Rea

if (e.command === 'hide-popover') {
this.host.hidePopover();
this.#clearInterestTimeout();
}

if (e.command === 'show-popover') {
Expand Down Expand Up @@ -167,7 +172,10 @@ export class TypeNativePopoverController<T extends NativePopover> implements Rea

hostDisconnected() {
this.#observers.forEach(observer => observer.disconnect());
this.#clearInterestTimeout();
}

#clearInterestTimeout() {
if (this.#interestTimeout) {
clearTimeout(this.#interestTimeout);
this.#interestTimeout = null;
Expand Down