[state-driver] check driver daemons startup status through sentinel file - #2727
Open
tariq1890 wants to merge 1 commit into
Open
[state-driver] check driver daemons startup status through sentinel file#2727tariq1890 wants to merge 1 commit into
tariq1890 wants to merge 1 commit into
Conversation
tariq1890
requested review from
cdesiniotis,
karthikvetrivel,
rahulait,
rajathagasthya and
shivamerla
as code owners
August 10, 2026 22:21
|
coverage: 38.385% (-0.08%) from 38.466% — daemons-status-file into main |
tariq1890
force-pushed
the
daemons-status-file
branch
from
August 11, 2026 00:19
531948c to
48b5707
Compare
Contributor
|
looks good to me! |
rahulait
reviewed
Aug 11, 2026
Signed-off-by: Tariq Ibrahim <tibrahim@nvidia.com>
tariq1890
force-pushed
the
daemons-status-file
branch
from
August 11, 2026 16:07
48b5707 to
d1c42d6
Compare
Contributor
|
One quick question: what will happen if the user started with newer operator and newer driver image, then driver image wrote NotReady to that status file and fails to start the daemons correctly. If the user has to switch to an older image say which is working fine, will the operator be able to proceed in that case as the status file still exists on node with NotReady state? Or, will it be able to clear it and continue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is accompanied by the driver-container PR NVIDIA/gpu-driver-container#913.
We introduce a new sentinel file called
.driver-daemons-statuswhich will help the driver container ensure that the Fabric Manager and other daemons are all fully up and running before the driver container goes into theRunningstate.For reasons of backward compatibility, we only enforce this check if the
.driver-daemons-statusfile is present. This way, the operator will continue to work with other driver containers that don't have this capability