Revert "Stop defaulting deprecated cdi.default in ClusterPolicy"

[tariq1890]

This reverts commit 62de6b5.

• We do not typically make non-additive changes to a CRD
• This change was made in response to an ArgoCD behaviour, which is just one among several tools for Kubernetes application deployment
• The issue is well-known and there is a well-documented solution. Enabling server-side diff strategy in ArgoCD fixes the issue for Argo users who face this problem. That is a better solution than making an upstream CRD schema change

[coderabbitai]

📝 Walkthrough

Walkthrough

The change adds a Kubernetes default of false to the deprecated CDIConfigSpec.Default field in api/nvidia/v1/clusterpolicy_types.go.

Merge Risk: 🟡 Moderate · up to 5c06b

This changes how omitted cdi.default values are materialized in ClusterPolicy resources, potentially affecting object shape and patch/apply behavior during upgrades. The compatibility impact should be justified or the marker reverted before merge.

---

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Actionable comments posted: 1

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: QUIET

Plan: Enterprise

Run ID: 831e8d79-94b3-4b11-851d-dbe8c82b99af

📥 Commits

Reviewing files that changed from the base of the PR and between 08c40bc and 5c06bce.

⛔ Files ignored due to path filters (3)

• bundle/manifests/nvidia.com_clusterpolicies.yaml is excluded by !bundle/manifests/nvidia.com_*.yaml
• config/crd/bases/nvidia.com_clusterpolicies.yaml is excluded by !config/crd/bases/**
• deployments/gpu-operator/crds/nvidia.com_clusterpolicies.yaml is excluded by !deployments/gpu-operator/crds/**

📒 Files selected for processing (1)

• api/nvidia/v1/clusterpolicy_types.go

Included review availability: Your plan provides up to 12 included reviews per hour; 9 remain after this review.

[coveralls]

coverage: 37.979%. remained the same — revert-pr2796 into main