feat: add public subnet and NAT gateway for cluster mode - #722
Closed
ArangoGutierrez wants to merge 1 commit into
Closed
feat: add public subnet and NAT gateway for cluster mode#722ArangoGutierrez wants to merge 1 commit into
ArangoGutierrez wants to merge 1 commit into
Conversation
Introduce Transport interface so each provider controls how SSH connections are established. DirectTransport for single-node and SSH provider. SSMTransport for AWS cluster mode with retry-based dial (D1). Provisioner unchanged — just receives working connections. - Transport interface with Dial() and Target() methods - DirectTransport: TCP dial to host:22 (existing behavior) - SSMTransport: AWS SSM port forwarding with exponential backoff retry - Provisioner gets functional option WithTransport() - NodeInfo gets InstanceID and Transport fields - Backwards compatible: nil transport falls back to DirectTransport Signed-off-by: Carlos Eduardo Arango Gutierrez <eduardoa@nvidia.com>
Collaborator
Author
|
Created against wrong branch, recreating |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
createPublicSubnet()for public subnet (10.0.1.0/24)createNATGateway()with EIP allocation and cleanup on failure (D4)createPublicRouteTable()andcreatePrivateRouteTable()for dual route tablesArchitecture Decision
D4: EIP cleanup on NAT GW failure. Design: docs/plans/2026-03-12-production-grade-clusters-design.md
Test plan