Skip to content

Drop duplicate value from devspace values.yaml#3793

Merged
kensimon merged 1 commit into
NVIDIA:mainfrom
kensimon:drop-duplicate-legacy-alias
Jul 22, 2026
Merged

Drop duplicate value from devspace values.yaml#3793
kensimon merged 1 commit into
NVIDIA:mainfrom
kensimon:drop-duplicate-legacy-alias

Conversation

@kensimon

Copy link
Copy Markdown
Contributor

Looks like two PR's both added it and now it's in there twice.

Related issues

Type of Change

  • Add - New feature or capability
  • Change - Changes in existing functionality
  • Fix - Bug fixes
  • Remove - Removed features or deprecated functionality
  • Internal - Internal changes (refactoring, tests, docs, etc.)

Breaking Changes

  • This PR contains breaking changes

Testing

  • Unit tests added/updated
  • Integration tests added/updated
  • Manual testing performed
  • No testing required (docs, internal refactor, etc.)

Additional Notes

Looks like two PR's both added it and now it's in there twice.
@kensimon
kensimon requested a review from a team as a code owner July 21, 2026 18:13
@coderabbitai

coderabbitai Bot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 367ba053-8371-4177-a568-9cf1df2c98da

📥 Commits

Reviewing files that changed from the base of the PR and between b2f9ff1 and e5bc836.

📒 Files selected for processing (1)
  • dev/deployment/devspace/values.base.yaml
💤 Files with no reviewable changes (1)
  • dev/deployment/devspace/values.base.yaml

Summary by CodeRabbit

  • Chores
    • Updated deployment resource allocations for improved runtime capacity and baseline availability.
    • Maintained the legacy alias setting as disabled.

Walkthrough

Updated the devspace deployment values for nico-api with CPU and memory requests and limits, while retaining the existing webAuth.mode configuration.

Changes

Devspace resource sizing

Layer / File(s) Summary
Configure nico-api resources
dev/deployment/devspace/values.base.yaml
Sets resource limits to 16 CPU and 16Gi memory, requests to 1 CPU and 1Gi memory, and retains the following webAuth.mode value.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the main change: removing a duplicated devspace value.
Description check ✅ Passed The description is directly related, explaining that the value was added twice and needs cleanup.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@kensimon
kensimon enabled auto-merge (squash) July 22, 2026 14:46
@kensimon
kensimon merged commit 2118746 into NVIDIA:main Jul 22, 2026
108 of 110 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants