fix: Introduce delay after power Off in dpf handling.#3906
Merged
Conversation
Contributor
Summary by CodeRabbit
WalkthroughThe DPF reboot handler now applies the configured power-transition delay unconditionally through the timestamp-based wait check before completing the ChangesDPF reboot state machine
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@crates/machine-controller/src/handler/dpf.rs`:
- Around line 328-333: Scope the wait gate around super::wait to the
PerformPowerOperation::On branch in the handler’s operation match, so only On
transitions return the waiting outcome during the Off→On delay. Ensure the Off
branch reads the current power state and can issue ForceOff without being
blocked by this delay.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: beb86c1c-42fb-4392-a218-707348d17b7d
📒 Files selected for processing (1)
crates/machine-controller/src/handler/dpf.rs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to enqueue based event handling, On is triggered immediately after Off while chassis is not able to process Off completely. So this time delay is needed.
Related issues
Type of Change
Breaking Changes
Testing
Additional Notes