Skip to content

devspace: Don't disable RBAC - #4668

Merged
kensimon merged 1 commit into
NVIDIA:mainfrom
kensimon:devspace-rbac
Aug 6, 2026
Merged

devspace: Don't disable RBAC#4668
kensimon merged 1 commit into
NVIDIA:mainfrom
kensimon:devspace-rbac

Conversation

@kensimon

@kensimon kensimon commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Running with RBAC disabled can make API's with incorrect RBAC settings seem like they work correctly when they don't... devspace's config overrides should be limited to areas where we can't easily simulate production (like disabling attestion and using a mock ipmitool.)

Related issues

#4631
#4341

Type of Change

  • Add - New feature or capability
  • Change - Changes in existing functionality
  • Fix - Bug fixes
  • Remove - Removed features or deprecated functionality
  • Internal - Internal changes (refactoring, tests, docs, etc.)

Breaking Changes

  • This PR contains breaking changes

Testing

  • Unit tests added/updated
  • Integration tests added/updated
  • Manual testing performed
  • No testing required (docs, internal refactor, etc.)

Deployed via devspace and verified that I could reproduce the bug in #4341

Additional Notes

Running with RBAC disabled can make API's with
incorrect RBAC settings seem like they work correctly when they don't...
devspace's config overrides should be limited to areas where we can't
easily simulate production (like disabling attestion and using a mock
ipmitool.)
@kensimon kensimon added this to the v2.2 milestone Aug 6, 2026
@kensimon
kensimon requested a review from a team as a code owner August 6, 2026 12:54
@kensimon kensimon linked an issue Aug 6, 2026 that may be closed by this pull request
@coderabbitai

coderabbitai Bot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: d12592d6-569c-49a4-b220-e4efeb05d286

📥 Commits

Reviewing files that changed from the base of the PR and between 4f0e11f and c98feec.

📒 Files selected for processing (1)
  • dev/deployment/devspace/values.base.yaml
💤 Files with no reviewable changes (1)
  • dev/deployment/devspace/values.base.yaml

Summary by CodeRabbit

  • Bug Fixes
    • Removed the setting that bypassed role-based access controls in the API configuration, ensuring access permissions are enforced as intended.

Walkthrough

The devspace base values no longer set bypass_rbac = true for the nico-api site configuration.

Changes

Devspace RBAC Configuration

Layer / File(s) Summary
Remove nico-api RBAC override
dev/deployment/devspace/values.base.yaml
Removes the bypass_rbac configuration override from the nico-api site configuration.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the main change: DevSpace no longer disables RBAC.
Description check ✅ Passed The description explains why RBAC must remain enabled, identifies the configuration scope, and documents manual testing.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@kensimon
kensimon enabled auto-merge (squash) August 6, 2026 13:50
@kensimon
kensimon merged commit c529f58 into NVIDIA:main Aug 6, 2026
65 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Default devspace configuration has bypass_rbac = true

2 participants