devspace: Don't disable RBAC - #4668
Merged
Merged
Conversation
Running with RBAC disabled can make API's with incorrect RBAC settings seem like they work correctly when they don't... devspace's config overrides should be limited to areas where we can't easily simulate production (like disabling attestion and using a mock ipmitool.)
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
Summary by CodeRabbit
WalkthroughThe devspace base values no longer set ChangesDevspace RBAC Configuration
Estimated code review effort: 1 (Trivial) | ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
kensimon
enabled auto-merge (squash)
August 6, 2026 13:50
ianderson-nvidia
approved these changes
Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Running with RBAC disabled can make API's with incorrect RBAC settings seem like they work correctly when they don't... devspace's config overrides should be limited to areas where we can't easily simulate production (like disabling attestion and using a mock ipmitool.)
Related issues
#4631
#4341
Type of Change
Breaking Changes
Testing
Deployed via devspace and verified that I could reproduce the bug in #4341
Additional Notes