fix(api): support Scout firmware upgrades for assigned hosts (#5569) - #5575
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
…5569) Fix Scout firmware upgrades for machines in Assigned/HostReprovision/WaitingForScoutUpgrade. I missed the fact that `WaitingForScoutUpgrade` can be nested inside the `Assigned` state so scout won't know about this work currently. This PR fixes it. - [ ] **Add** - New feature or capability - [ ] **Change** - Changes in existing functionality - [x] **Fix** - Bug fixes - [ ] **Remove** - Removed features or deprecated functionality - [ ] **Internal** - Internal changes (refactoring, tests, docs, etc.) - [x] Unit tests added/updated - [ ] Integration tests added/updated - [ ] Manual testing performed - [ ] No testing required (docs, internal refactor, etc.) The API now: - Dispatches firmware upgrade tasks for assigned hosts. - Accepts Scout completion reports while preserving the Assigned state wrapper. - Adds regression tests for both paths. ci-rebuild-base-containers (cherry picked from commit 288755f) Signed-off-by: Jakhongir Rakhmonov <jrakhmonov@nvidia.com>
rahmonov
force-pushed
the
backport-5569-v0.10
branch
from
August 31, 2026 11:05
afe0c05 to
dd978c3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backporting 288755f (#5569) to v0.10.0