Remove cli run-once and disable-blocking-kernel options#254
Merged
oleksandr-pavlyk merged 7 commits intoJul 28, 2025
Conversation
Removed option_parser::disable_blocking_kernel and option_parse::set_run_once methods. Added option_parser::enable_profile method instead, which calls ``` bench.set_run_once(true); bench.disable_blocking_kernel(true); ```
The text printed when blocking kernel times out already suggests to use --profile option.
Text for --profile modified to be self-consistent, i.e., not to refer to removed --run-once and --disable-blocking-kernel for explanantion of what it does.
gevtushenko
requested changes
Jul 28, 2025
Verify that `--profile` option results in setting `m_run_once`: ``` (nvbench) opavlyk@ee09c48-lcedt:~/repos/nvbench$ ./build/bin/nvbench.example.cpp20.axes -b simple -d 0 --profile | grep "Pass: Cold" Pass: Cold: 1.006560ms GPU, 1.009277ms CPU, 0.00s total GPU, 0.00s total wall, 1x (nvbench) opavlyk@ee09c48-lcedt:~/repos/nvbench$ ./build/bin/nvbench.example.cpp20.axes -b simple -d 0 | grep "Pass: Cold" Pass: Cold: 1.002844ms GPU, 1.011917ms CPU, 0.50s total GPU, 0.52s total wall, 499x ```
alliepiper
approved these changes
Jul 28, 2025
alliepiper
left a comment
alliepiper
left a comment
Contributor
There was a problem hiding this comment.
LGTM with a small tweak to make the docs more user-friendly.
Spare users of implementation details in description of `--profile` option Co-authored-by: Allison Piper <apiper@nvidia.com>
oleksandr-pavlyk
changed the title
gevtushenko
approved these changes
Jul 28, 2025
oleksandr-pavlyk
deleted the
remove-cli-run-once-and-disable-blocking-kernel-options
branch
July 28, 2025 20:10
This was referenced Jul 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes gh-253
Removes support for
--run-onceand--disable-blocking-kernelfromnvbench::option_parser.nvbench::option_parser::enable_run_once()andnvbench::option_parser::disable_blocking_kernel().nvbench::option_parser::enable_profile()that callsbench.set_run_once(true);andbench.disable_blocking_kernel(true);--disable-blocking-kerneloption. The text already suggests using--profilecommand-line option.