fix(self-managed): configure LLM router worker address - #679
Open
mikeyrcamp wants to merge 6 commits into
Open
Conversation
Signed-off-by: Mike Camp <mcamp@nvidia.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
4 tasks
Contributor
kristinapathak
approved these changes
Aug 5, 2026
Use the colocated request-router service when the worker endpoint override is empty. Document the field as a split-cluster override. Relates to #676
mikeyrcamp
enabled auto-merge (squash)
August 5, 2026 17:58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
Backport the reviewed self-managed LLM request-router worker-address contract to the v0.7 release branch. Colocated deployments use the cluster-local service by default, while split deployments can provide a worker-reachable override.
Additional Details
Why
The v0.7 stack did not populate the LLM request-router worker address consumed by generated LLM workers. Compute agents can reject LLM launches without that address. The release needs a safe colocated default and a topology-owned override for split deployments.
What changed
global.workerEndpoints.llmRequestRouterAddressas an optional topology override.llm-request-router.nvcf.svc.cluster.local:50071.host:portand bracketed IPv6host:portoverrides, including port bounds.api.remoteConfig.configData.nvcf.llm-request-router.worker-address.Customer Release Notes
Self-managed v0.7 LLM deployments with colocated workers now use
llm-request-router.nvcf.svc.cluster.local:50071automatically. Split deployments must overrideglobal.workerEndpoints.llmRequestRouterAddresswith a request-router host and port reachable from worker pods.Plan Summary
Configuration-only backport. No Kubernetes resources, chart versions, release pins, or replica counts are changed.
Usage
Colocated deployments require no additional worker-address configuration. The cluster-local address follows
addons.llm.requestRouter.service.grpcPortwhen a non-default service port is configured. For a split deployment, configure an override before enabling the LLM add-on:Testing
make -C deploy/stacks/self-managed testgo test -short ./...fromtests/bdd./tools/ci/check-docsgit diff --checkNotes
Split-cluster router network exposure is tracked separately in #689.
The v0.7 branch retains its existing stack and chart version pins. No API chart bump is required because v0.7 already pins a chart with the nested remote-config path.
References
Related Pull Requests
Dependencies
None. No third-party dependency, license, or NOTICE changes.
For the Reviewer
Please compare the default and explicit-override behavior with #678 and confirm the release branch retains its existing v0.7 version pins.
For QA
QA is recommended for one colocated and one split-cluster v0.7 LLM function launch. The focused render tests and non-live BDD suite are green.
Issues
Relates to #676
Checklist