feat(release): register nvcf-ui as a releasable subproject - #714
Merged
Conversation
nvcf-ui has a Bazel matrix row but no release entry, so `github-release auto` never considers it and no src/uis/nvcf-ui/v* tag is ever cut. The release lane waiting for that tag in nvcf-internal would sit idle forever. Registering it yields tag prefix src/uis/nvcf-ui/v from default_tag_format, which is what the nvcf-internal config expects. Note the generated_by header on this file is stale: tools/generate-subproject-ci and tools/ci/subproject-validations.yaml no longer exist in this repo, so the file is maintained by hand. Co-authored-by: Balaji Ganesan <bganesan@nvidia.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe GitHub release configuration now includes the ChangesGitHub release subproject registration
Estimated code review effort: 1 (Trivial) | ~2 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
kristinapathak
approved these changes
Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
nvcf-uihas a Bazel matrix row but no entry intools/ci/github-release-subprojects.json, sogithub-release autoneverconsiders it and no
src/uis/nvcf-ui/v*tag is ever cut. Without a tag therelease lane in nvcf-internal !122 can never fire.
What changed
One entry, 5 lines.
default_tag_formatthen yieldssrc/uis/nvcf-ui/v, whichis exactly the
tag_prefixnvcf-internal !122 was written against.Worth knowing: this file's
generated_byheader is stale.tools/generate-subproject-ciandtools/ci/subproject-validations.yamlare nolonger in the repo, so it is hand-maintained. I checked before assuming a regen
was needed.
Testing
python3 tools/ci/test-github-release.py— 20/20 pass. Loadedgithub-releasedirectly and confirmed the new entry resolves:
Not exercised: an actual release run, which needs
src/uis/nvcf-uion main.Notes
Merge after #662 — the path does not exist on main until the UI import lands.
Pairs with nvcf-internal !122, which consumes the tag.
Summary by CodeRabbit
nvcf-uiservice to automated GitHub release configuration.