fix(nvca): use worker-init transport TLS installer - #715
Closed
mikeyrcamp wants to merge 1 commit into
Closed
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
nvcf-trust-bundle-installin the standard worker-init image while keeping/worker-initas its entrypoint.initcontainer's image and pull policy for transport-trust installation; remove the separate installer-image configuration and NVCA image binary.Why
The installer must be published in worker-init before NVCA injects it. Deriving the installer image from the rendered
initcontainer keeps the image, pull policy, and rollout metadata aligned. Missing or image-less regular init containers now terminally fail bundle-enabled LLM Pods.This is stacked on #708 and targets its branch so the prior mount-path work remains separate.
Fixes #713
Validation
go test ./cmd/nvcf-trust-bundle-install -count=1go test ./internal/transporttls -count=1go test ./pkg/trustbundle ./pkg/types/nvca/config -count=1bazel test //pkg/operator/reconcile:reconcile_test --test_filter='Test(ConfigMapAddHandler_SkipsInitialListForOperatorConfig|SyncCurrentBackendForConfigMapChange_WrapsError|ConfigMapChangesForceNVCAReconcile)'bazel test //internal/miniservice:miniservice_test --test_filter='Test.*TransportTLS'bazel test //pkg/nvca:nvca_test --test_filter='Test.*TransportTLS'bazel test //cmd:image_contents_test //cmd/nvcf-trust-bundle-install:nvcf-trust-bundle-install_testThe complete reconciliation Bazel target is blocked locally by an unchanged macOS test helper: it cannot patch
os.Exitand then dereferences the nil patch in cleanup. The targeted reconciliation tests above pass in the same Bazel environment.