feat(nvca): default self-managed BYOO collector - #720
Open
kristinapathak wants to merge 2 commits into
Open
Conversation
Default function and task workloads to BYOO 0.157.11 and include the injected image in release SBOM inputs. Closes #719 Signed-off-by: Kristina Pathak <kpathak@nvidia.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThe chart sets a default BYOO OTel collector image for function and task workloads. Vendor and release scripts propagate and extract the image. Tests validate matching defaults and supplemental image manifest inclusion. ChangesBYOO collector image support
Estimated code review effort: 3 (Moderate) | ~20 minutes Suggested reviewers: Sequence Diagram(s)sequenceDiagram
participant Chart
participant VendorScript
participant RenderedManifest
participant ImageRenderer
participant ReleaseTests
Chart->>VendorScript: provide collector image default
VendorScript->>RenderedManifest: write function/task overrides
RenderedManifest->>ImageRenderer: provide encoded overrides
ImageRenderer->>ImageRenderer: decode and validate image references
ImageRenderer->>ReleaseTests: generate supplemental image manifest
ReleaseTests->>ReleaseTests: verify image inclusion and validation errors
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
deploy/helm/nvca-operator/tests/release_image_manifest_test.sh (1)
45-47: 🗄️ Data Integrity & Integration | 🔵 Trivial | ⚡ Quick winCover the task override path in this release test.
The fixture supplies only
--function-env-overrides-b64. Add the matching--task-env-overrides-b64argument. Keep the exact-six assertion to verify that the same collector image is deduplicated.As per coding guidelines, code changes must include tests.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@deploy/helm/nvca-operator/tests/release_image_manifest_test.sh` around lines 45 - 47, Add the matching --task-env-overrides-b64 argument to the fixture alongside --function-env-overrides-b64, using the same collector image override so the release test exercises task overrides and deduplication. Preserve the exact-six assertion and update or add test coverage as needed for this path.Source: Coding guidelines
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@deploy/helm/nvca-operator/scripts/render_release_supplemental_images.sh`:
- Around line 142-147: Update the BYOO_OTEL_COLLECTOR_CONTAINER handling around
byoo_otel_collector_image to parse the decoded JSON and validate the complete
image reference, rejecting malformed values such as repo/image:. If the key is
present but invalid, emit an error and return non-zero instead of silently
omitting it; retain the existing supplemental-image output for valid references.
---
Nitpick comments:
In `@deploy/helm/nvca-operator/tests/release_image_manifest_test.sh`:
- Around line 45-47: Add the matching --task-env-overrides-b64 argument to the
fixture alongside --function-env-overrides-b64, using the same collector image
override so the release test exercises task overrides and deduplication.
Preserve the exact-six assertion and update or add test coverage as needed for
this path.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 0c10cfaf-cff1-4329-b469-8e0296220c70
📒 Files selected for processing (5)
deploy/helm/nvca-operator/nvca-operator/values.yamldeploy/helm/nvca-operator/scripts/ci_vendor_nvca_operator_chartdeploy/helm/nvca-operator/scripts/render_release_supplemental_images.shdeploy/helm/nvca-operator/tests/release_image_manifest_test.shdeploy/helm/nvca-operator/tests/self_managed_nvca_image_reference_test.sh
Fail release SBOM generation when encoded BYOO image overrides are malformed. Cover task override deduplication. Relates to #719 Signed-off-by: Kristina Pathak <kpathak@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
Additional Details
BYOO_OTEL_COLLECTOR_IMAGEfrom local.envor CI.For the Reviewer
For QA
make lintmake templatemake validateIssues
Closes #719
Checklist
Github
Github commit:
feat(nvca): default self-managed BYOO collector
Default function and task workloads to BYOO 0.157.11 and include the injected
image in release SBOM inputs.
Summary by CodeRabbit
New Features
Bug Fixes
Tests