fix(nvca-operator): sync PodDisruptionBudget chart

[kristinapathak]

TL;DR

• Synchronize the NVCA Operator PodDisruptionBudget from its shipped chart into source, schema, documentation, and generated output.

Additional Details

• The PDB was added to the packaged chart in feat(helm): expose PodDisruptionBudget via values across all charts #808 without its source chart counterpart.
• Validate integer and 0-100% availability values before rendering.
• Preserve the template rule that enabled PDBs set exactly one availability field.

For the Reviewer

• Compare the source chart with the regenerated vendor output.

For QA

• make test-pod-disruption-budget
• make lint
• make template
• make validate
• NVCA_OPERATOR_VERSION=3.0.4 NVCA_VERSION=3.0.4 NVCA_SHARED_STORAGE_IMAGE_TAG=1.0.5 make check-vendor-chart
• QA needed: No. Source and vendor render coverage validates the behavior.

Issues

Closes #972

Checklist

• I am familiar with the Contributing Guidelines.
• I have signed off my commits for Developer Certificate of Origin (DCO) compliance.
• New or existing tests cover these changes.
• The documentation is up to date with these changes.

Summary by CodeRabbit

• New Features

  • Added optional PodDisruptionBudget support for the NVCA Operator Helm chart.
  • Configure minimum availability or maximum unavailability using numbers or percentages.
  • Added validation to prevent missing or conflicting availability settings.

• Documentation

  • Documented PodDisruptionBudget configuration and updated request-router address guidance.

• Tests

  • Added coverage for valid, default, and invalid PodDisruptionBudget configurations.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: d86889f6-5249-49ba-9470-7de8f95cbc26

📥 Commits

Reviewing files that changed from the base of the PR and between fcf08b6 and 3645aa7.

📒 Files selected for processing (10)

• deploy/helm/nvca-operator/Makefile
• deploy/helm/nvca-operator/nvca-operator/README.md
• deploy/helm/nvca-operator/nvca-operator/values.schema.json
• deploy/helm/nvca-operator/nvca-operator/values.yaml
• deploy/helm/nvca-operator/tests/pod_disruption_budget_test.sh
• src/compute-plane-services/nvca/deployments/nvca-operator/README.md
• src/compute-plane-services/nvca/deployments/nvca-operator/templates/operator-networkpolicy.yaml
• src/compute-plane-services/nvca/deployments/nvca-operator/templates/poddisruptionbudget.yaml
• src/compute-plane-services/nvca/deployments/nvca-operator/values.schema.json
• src/compute-plane-services/nvca/deployments/nvca-operator/values.yaml

Included review availability: Your plan provides up to 12 included reviews per hour; 10 remain after this review.

---

📝 Walkthrough

Walkthrough

The NVCA Operator Helm charts now support optional PodDisruptionBudgets. Values schemas validate availability settings, templates enforce mutual exclusivity, documentation describes configuration, and tests cover source and vendored charts.

Changes

PodDisruptionBudget chart support

Layer / File(s)	Summary
Source chart configuration and rendering src/compute-plane-services/nvca/deployments/nvca-operator/...	The source chart adds PodDisruptionBudget defaults, schema validation, conditional rendering, and an HTTPS SPDX URL.
Vendored chart synchronization and documentation deploy/helm/nvca-operator/nvca-operator/..., src/compute-plane-services/nvca/deployments/nvca-operator/README.md	The vendored chart receives matching schema and documentation. Request-router documentation now refers to LLM_REQUEST_ROUTER_ADDRESS from the launch environment.
Chart validation and test wiring deploy/helm/nvca-operator/tests/pod_disruption_budget_test.sh, deploy/helm/nvca-operator/Makefile	Tests cover linting, disabled defaults, valid availability settings, and invalid configurations for both charts. A Make target runs the test script.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Merge Risk: ⚪ Minimal · up to 3645a

This PR synchronizes the PodDisruptionBudget source, schema, documentation, and generated chart output with validation coverage; no actionable merge-blocking risk remains beyond normal checks and review.

Sequence Diagram(s)

sequenceDiagram
  participant HelmValues
  participant ValuesSchema
  participant PDBTemplate
  participant RenderedManifest
  HelmValues->>ValuesSchema: validate podDisruptionBudget settings
  ValuesSchema->>PDBTemplate: provide validated values
  PDBTemplate->>RenderedManifest: render optional PodDisruptionBudget

Loading

Possibly related PRs

• NVIDIA/nvcf#968: Modifies overlapping NVCA Operator PodDisruptionBudget chart configuration, templates, and documentation.

Suggested reviewers: apartha-nv

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Out of Scope Changes check	⚠️ Warning	The SPDX license URL change is unrelated to the PodDisruptionBudget synchronization objectives.	Remove the unrelated SPDX license URL change or provide a clear issue-related justification for it.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title follows Conventional Commits and accurately describes the PodDisruptionBudget chart synchronization fix.
Linked Issues check	✅ Passed	The changes satisfy issue #972 by synchronizing charts, validating PDB values, documenting configuration, and testing source and vendored renders.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch kpathak/fix-nvca-operator-pdb-source

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 Trivy (0.73.0)

Trivy execution failed: 2026-08-18T22:36:12Z FATAL Fatal error run error: fs scan error: scan error: scan failed: failed analysis: post analysis error: post analysis error: ansible scan error: fs filter error: fs filter error: walk error range error: stat markdownlint-cli2-results-0.json: no such file or directory: range error: stat markdownlint-cli2-results-0.json: no such file or directory

---

_{Comment @coderabbitai help to get the list of available commands.}