-
Notifications
You must be signed in to change notification settings - Fork 441
Fix: Local yum repo not enabled by default in centos8 and fedora35 entrypoints #1196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Sanjay Jangid <sanjayjangid20m@gmail.com>
Signed-off-by: Sanjay Jangid <sanjayjangid20m@gmail.com>
|
any changes needed !! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes a critical issue where local YUM repositories were not being enabled by default in CentOS 8 and Fedora 35 test environments, causing locally built RPM packages to be ignored during testing.
- Changed repository configuration from
enabled=0toenabled=1to activate local repos by default - Updated baseurl to use the
${LOCAL_REPO_DIRECTORY}environment variable instead of hardcoded path - Removed unreliable
yum-config-manager --enablecommand that could fail silently in CI environments
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/release/docker/fedora35/entrypoint.sh | Updated local repo configuration to enable by default and use correct baseurl |
| tests/release/docker/centos8/entrypoint.sh | Updated local repo configuration to enable by default and use correct baseurl |
ArangoGutierrez
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @sanjay20m thanks for the contribution, could you squash the 2 commits into one, thanks!
|
Hey @ArangoGutierrez Let me know if you'd prefer I keep trying locally — I’ll do my best. Thanks again for your time and help! |
| : ${LOCAL_REPO_DIRECTORY:=/local-repository} | ||
| if [[ -d ${LOCAL_REPO_DIRECTORY} ]]; then | ||
| echo "Setting up local-repository" | ||
| createrepo /local-repository |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should also update this to use the envvar.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
check this out : commit 798726f68fa675f3a34a5e902e3a4206540b758c
!!
Use LOCAL_REPO_DIRECTORY in createrepo command
Signed-off-by: Author Name sanjayjangid20m@gmail.com
Signed-off-by: Sanjay Jangid <sanjayjangid20m@gmail.com>
|
Hi @ArangoGutierrez , @elezar Apologies for the multiple commits made for a single logical change — I encountered some issues and glitches while trying to squash them locally and through GitHub's web interface. I understand the preference for clean commit history, and I truly appreciate your patience. If possible, could you please squash the commits while merging the PR? I’d be really grateful for your cooperation and understanding. Thanks again for reviewing and guiding the patch! |
Signed-off-by: Sanjay Jangid <136222049+sanjay20m@users.noreply.github.com>
|
Very sorry, I am trying to fix it, but it is failing due to some issues. Please cooperate... |
Summary
This patch fixes an issue in the
entrypoint.shscripts for both CentOS 8 and Fedora 35 where the local YUM repository was not being used by default during test runs.Issue
Even though the script creates a local YUM repository file (
local.repo), it was configured withenabled=0, which means it is disabled by default. Whileyum-config-manager --enable local-repositorywas called, this is not always reliable in automated or minimal environments (e.g. CI containers) and may fail silently or be skipped.As a result, any locally built RPM packages are not actually used during testing, making the
local-repositorysetup ineffective.Fix
enabled=0toenabled=1directly in the.repofile to ensure it's active by default.baseurlusing the${LOCAL_REPO_DIRECTORY}environment variable.yum-config-manager --enable local-repository.Impact