Fix:Local yum repo not enabled by default in centos8 and fedora35 entrypoints #1205
Conversation
…ints
- Changed enabled=0 to enabled=1 in local.repo
- Updated baseurl to use ${LOCAL_REPO_DIRECTORY}
- Removed redundant yum-config-manager --enable command
- Ensures local RPMs are properly tested in CI for both CentOS8 and Fedora35
Signed-off-by: Sanjay Jangid <136222049+sanjay20m@users.noreply.github.com>
|
I've rebased the branch, squashed the commits into a single logical change, and ensured the Signed-off-by is correct Please review the updated PR. Thank you for your guidance and patience! |
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a critical issue where local YUM repositories were not being used by default in CentOS 8 and Fedora 35 test environments, despite being configured. The fix ensures that locally built RPM packages are properly tested in CI by enabling the repository directly in the configuration file.
- Changed repository configuration from
enabled=0toenabled=1to activate local repos by default - Updated hardcoded paths to use the
LOCAL_REPO_DIRECTORYenvironment variable for consistency - Removed unreliable
yum-config-manager --enablecommand that could fail silently in minimal environments
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/release/docker/fedora35/entrypoint.sh | Updates local repo setup to enable by default and use variable paths |
| tests/release/docker/centos8/entrypoint.sh | Identical fixes to fedora35 plus removal of redundant yum-config-manager call |
Comments suppressed due to low confidence (1)
ArangoGutierrez
left a comment
ArangoGutierrez
left a comment
There was a problem hiding this comment.
lgtm - Thoughts @elezar ?
|
Hi @elezar I noticed this PR hasn’t been reviewed yet. Just wanted to check if there are any issues on my side or anything else I should address. Please let me know. |
elezar
left a comment
elezar
left a comment
There was a problem hiding this comment.
Thanks @sanjay20m. These are containers that test basic package functionality, but the change are appreciated.
Pull Request Test Coverage Report for Build 16469767223Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
|
Thank you very much for the review and feedback! Please let me know if there’s anything else I should address. I truly appreciate your time and consideration, and I’m looking forward to the merge whenever it’s convenient. |
4 participants
Summary
This patch fixes an issue in the entrypoint.sh scripts for both CentOS 8 and Fedora 35 where the local YUM repository was not being used by default during test runs.
Issue
Even though the script creates a local YUM repository file (local.repo), it was configured with enabled=0, which means it is disabled by default. While yum-config-manager --enable local-repository was called, this is not always reliable in automated or minimal environments (e.g. CI containers) and may fail silently or be skipped.
As a result, any locally built RPM packages are not actually used during testing, making the local-repository setup ineffective.
Fix
Changed enabled=0 to enabled=1 directly in the .repo file to ensure it's active by default.
Set the correct baseurl using the ${LOCAL_REPO_DIRECTORY} environment variable.
Removed the redundant call to yum-config-manager --enable local-repository.
Impact
Ensures local RPMs are tested properly in CI.
Fixes misleading behavior where the script pretended to use the local repo but didn’t.
Helps catch packaging or integration issues earlier in the CI pipeline.
IMP NOTE: Previous PR (#1196) had issues during squash/sign-off process due to local setup constraints. This PR is the corrected version and replaces the old one. Thank you for your understanding and patience!