fuzz: match exact expect messages, not broad prefix - #191
Merged
Conversation
Substring "nvrc.smi." could mask unrelated panics that happen to mention that prefix; match the three exact .expect() messages instead. Signed-off-by: Zvonkou Kaiser <zkaiser@nvidia.com> Assisted-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR tightens the fuzz target’s panic filtering for process_kernel_params() by replacing a broad substring match ("nvrc.smi.") with an allowlist of specific expected panic messages, so unrelated panics aren’t accidentally ignored during fuzzing.
Changes:
- Replace broad
"nvrc.smi."substring filtering with an allowlist of three expectednvrc.smi.*validation messages. - Centralize the expected messages into a
const EXPECTEDslice for clearer intent.
.expect("msg") panics with "msg: <parse error>" appended, so exact
equality never matches; starts_with handles the suffix correctly.
Signed-off-by: Zvonkou Kaiser <zkaiser@nvidia.com>
Assisted-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Substring "nvrc.smi." could mask unrelated panics that happen to mention that prefix; match the three exact .expect() messages instead.
Assisted-By: Claude Sonnet 4.6 noreply@anthropic.com