Add the ability to set stdin for a Process #2
+257
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cursor written changes pass cargo testing, but python tests hang. Committing to move to a new client that with a more consistent python setup in case that hang is from the version problems.
Passes relevant cargo and pants tests. Still needs to be tried with a real build process. Also needs a round of review & cleanup of the Cursor generated code - especially the rust.
Delete a bunch of leftover logger calls
Remove superfluous comments, debug prints, and tests. Default stdin on Process to None to preserve the distinction between no stdin and stdin of a 0-byte string. Error out on remote execution with stdin instead of forcing to local
Added one sentence to the release notes. Made all of the fixes required by both rust and python lint tools
Pull Request Test Coverage Report for Build 21044890724Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Collaborator
Author
|
PR sent directly to mainline. Closing here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new optional field to Process objects of the bytes to be passed into the command's stdin. This has the unfortunate side effect of requiring the command to run locally because the Remote Execution API doesn't support stdin (yet).