Skip to content

Migrate XAeroNet example to PyTorch Geometric#1037

Merged
Alexey-Kamenev merged 17 commits intoNVIDIA:mainfrom
Alexey-Kamenev:pyg-xaeronet
Aug 4, 2025
Merged

Migrate XAeroNet example to PyTorch Geometric#1037
Alexey-Kamenev merged 17 commits intoNVIDIA:mainfrom
Alexey-Kamenev:pyg-xaeronet

Conversation

@Alexey-Kamenev
Copy link
Collaborator

@Alexey-Kamenev Alexey-Kamenev commented Jul 29, 2025 •
edited
Loading

PhysicsNeMo Pull Request

Description

Migrated XAeroNet example to PyTorch Geometric.

Key Changes

  1. Added PyG-based XAeroNet example. The PyG version should have feature parity, including graph partitioning using METIS, halo regions support an so on.
  2. Renamed existing DGL-based example to xaeronet_dgl
  3. Added unit tests to PyG version of XAeroNet.

Training loss curve DGL (blue) vs PyG (orange):

image

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.
  • The CHANGELOG.md is up to date with these changes.
  • An issue is linked to this pull request.

Dependencies

@Alexey-Kamenev
Copy link
Collaborator Author

Alexey-Kamenev commented Jul 29, 2025

/blossom-ci

@Alexey-Kamenev
Copy link
Collaborator Author

Alexey-Kamenev commented Jul 30, 2025

/blossom-ci

@Alexey-Kamenev
Copy link
Collaborator Author

Alexey-Kamenev commented Jul 30, 2025

/blossom-ci

@Alexey-Kamenev
Copy link
Collaborator Author

Alexey-Kamenev commented Jul 31, 2025

/blossom-ci

@Alexey-Kamenev
Copy link
Collaborator Author

Alexey-Kamenev commented Jul 31, 2025

/blossom-ci

@Alexey-Kamenev Alexey-Kamenev added the ! - Release PRs or Issues releating to a release label Aug 1, 2025
@Alexey-Kamenev
Copy link
Collaborator Author

Alexey-Kamenev commented Aug 1, 2025

/blossom-ci

@Alexey-Kamenev
Copy link
Collaborator Author

Alexey-Kamenev commented Aug 1, 2025

/blossom-ci

@Alexey-Kamenev
Copy link
Collaborator Author

Alexey-Kamenev commented Aug 4, 2025

/blossom-ci

coreyjadams
coreyjadams approved these changes Aug 4, 2025
View reviewed changes
Copy link
Collaborator

@coreyjadams coreyjadams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Had just a minor nit about the requirements file to take a look at.

ktangsali
ktangsali approved these changes Aug 4, 2025
View reviewed changes
Copy link
Collaborator

@ktangsali ktangsali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Alexey-Kamenev
Copy link
Collaborator Author

Alexey-Kamenev commented Aug 4, 2025

/blossom-ci

@Alexey-Kamenev Alexey-Kamenev merged commit 3a251f6 into NVIDIA:main Aug 4, 2025
1 check passed
@Alexey-Kamenev Alexey-Kamenev deleted the pyg-xaeronet branch August 12, 2025 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coreyjadams coreyjadams coreyjadams approved these changes

@ktangsali ktangsali ktangsali approved these changes

@mnabian mnabian Awaiting requested review from mnabian

Assignees

No one assigned

Labels

! - Release PRs or Issues releating to a release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Alexey-Kamenev @coreyjadams @ktangsali