Skip to content

Update header_check.py#1039

Merged
coreyjadams merged 5 commits intomainfrom
coreyjadams-fix-license-precommit-deleted-files
Aug 1, 2025
Merged

Update header_check.py#1039
coreyjadams merged 5 commits intomainfrom
coreyjadams-fix-license-precommit-deleted-files

Conversation

@coreyjadams
Copy link
Collaborator

@coreyjadams coreyjadams commented Aug 1, 2025

Fix license header check: when files are deleted while other files are modified, it fails. This should make sure that the license check only runs on files not marked D for deleted - those get filtered out of the committed files list now.

Fixes #1009

PhysicsNeMo Pull Request

Description

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.
  • The CHANGELOG.md is up to date with these changes.
  • An issue is linked to this pull request.

Dependencies

Fix license header check: when files are deleted while other files are modified, it fails.  This should make sure that the license check only runs on files not marked `D` for deleted - those get filtered out of the committed files list now.
@coreyjadams coreyjadams requested a review from ktangsali August 1, 2025 13:00
@coreyjadams coreyjadams self-assigned this Aug 1, 2025
@coreyjadams coreyjadams added the bug Something isn't working label Aug 1, 2025
@coreyjadams
Copy link
Collaborator Author

/blossom-ci

Copy link
Collaborator

@ktangsali ktangsali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

Fix ruff qa is.
@coreyjadams
Copy link
Collaborator Author

/blossom-ci

add os import
@coreyjadams
Copy link
Collaborator Author

/blossom-ci

@coreyjadams
Copy link
Collaborator Author

/blossom-ci

@coreyjadams
Copy link
Collaborator Author

/blossom-ci

1 similar comment
@coreyjadams
Copy link
Collaborator Author

/blossom-ci

@coreyjadams coreyjadams merged commit bcff394 into main Aug 1, 2025
1 check passed
@coreyjadams coreyjadams deleted the coreyjadams-fix-license-precommit-deleted-files branch August 1, 2025 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🐛[BUG]: License pre-commit breaks when deleting files

2 participants